GeezerVison

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 15, 2026 11:27pm

PR Summary

Medium Risk
Touches drag-and-drop navigation across Files/Knowledge/Tables and bulk authorization paths; behavior is well-tested but manual drag/upload passes are worthwhile given Files switched code paths.

Overview
Foldered lists share one drag implementation again. Files drops its large duplicate handler and wires useFolderRowDragDrop with per-list dragMime, an externalDrop path for OS files onto folder rows (body/breadcrumb stay with the page upload overlay), and externalDropHandled() so spring navigation does not bounce away after upload.

Drop affordance state is a single ActiveDropTarget union (row / body / crumb) with armDropTarget identity reuse so continuous dragover does not re-render the whole list. Spring-loaded folders can open the same folder again in one drag after backing out via the breadcrumb; useSpringNavigation refuses arming the folder already on screen and cancels pending opens when hovering the current folder crumb.

Bulk move/delete for tables and knowledge bases resolves each item with resolveActiveTableInWorkspace / resolveActiveKnowledgeBaseInWorkspace using the workspace context already loaded for the batch (shared requireTable / requireKnowledgeBase helpers). Table tests assert workspace context loads once per batch and permissions are still checked per item.

UI: chipDropTargetSurfaceClass uses --surface-active plus inset outline instead of --surface-4 so drop targets read stronger in light mode.

^{Reviewed by Cursor Bugbot for commit 6ab3c6f. Configure here.}

Greptile Summary

The PR consolidates Files drag-and-drop behavior into the shared folder-list hook, improves spring navigation and drop-target state, restores per-surface drag payload isolation, and optimizes bulk resource context resolution while retaining per-item authorization checks.

• Adds external OS-file drop support to the shared folder-row drag hook.
• Reworks spring navigation to support repeated folder entry during one drag while preserving origin restoration.
• Replaces multiple drop-state booleans with one mutually exclusive active-target union.
• Reuses canonical workspace context during table and knowledge bulk operations without caching permission decisions.
• Updates drag lifecycle, authorization, and context-resolution tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

sequenceDiagram
  participant Request as Bulk request
  participant Bulk as Bulk operation
  participant Context as Canonical workspace context
  participant Auth as Workspace authorization
  participant DB as Database
  Request->>Bulk: Move or delete multiple items
  Bulk->>Context: Resolve workspace context once
  loop Each item
    Bulk->>DB: Resolve active resource in workspace
    Bulk->>Auth: Authorize current item
    Auth->>DB: Read current effective permission
    Auth-->>Bulk: Allow or reject
    Bulk->>DB: Commit authorized item
  end

_{Reviews (2): Last reviewed commit: "fix(resources): dismiss the upload overl..." | Re-trigger Greptile}

@greptile

@cursor review