GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(executor): preserve actors for actorless tool calls by TheodoreSpeaks · Pull Request #7230 · simstudioai/sim

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • build credential-group executor principals in process so actorless workflows can list credentials
  • preserve the legacy execution actor for personal resource lookup and attribution while keeping authorization principal-based
  • apply actorless compatibility across custom tools, credential access, Knowledge, file sharing, Windchill transfers, and workflow reverts

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run check:audits
  • bun run type-check in apps/sim
  • 173 focused tests

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vercel

vercel Bot commented Aug 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Aug 28, 2026 9:13pm

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@greptile-apps

greptile-apps Bot commented Aug 28, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR moves legacy actorless-execution compatibility into the trusted executor principal and removes separate execution-actor inputs from application use cases.

  • Adds a deployment-only, principal-bound compatibility actor for actorless executor delegations.
  • Uses that actor for personal credentials, custom tools, Knowledge, MCP, file-sharing, Windchill, and workflow-revert behavior while retaining principal-based workspace authorization and audit identity.
  • Constructs credential-group principals directly in process and adds focused compatibility and refusal-path tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed
Filename Overview
apps/sim/lib/internal/principals/executor.ts Binds the execution context user as a compatibility actor only when the trusted executor origin has no Sim-user subject.
apps/sim/lib/auth/internal-delegation.ts Adds validated compatibility-actor binding while rejecting empty actors and delegations that already have a user subject.
packages/auth/src/principal.ts Extends workflow delegation context with a deployment-only compatibility actor and resolves real principal subjects first.
apps/sim/lib/credentials/application/authorization.ts Centralizes credential execution-user resolution through the principal-bound compatibility policy.
apps/sim/lib/custom-tools/application/use-cases.ts Applies principal-derived execution-user scoping consistently to custom-tool reads, listings, updates, and deletes.
apps/sim/lib/knowledge/application/billing.ts Uses the principal-bound execution actor for Knowledge personal-resource and usage attribution paths.
apps/sim/lib/mcp/application/authorization.ts Removes caller-supplied execution identity and resolves MCP credential ownership from the principal.
apps/sim/lib/workspace-files/application/share-workspace-file.ts Preserves actorless deployment sharing behavior through the principal-bound execution actor.

Flowchart

 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Workflow execution context] --> B[Trusted executor adapter]
  B --> C{Principal has Sim user subject?}
  C -->|Yes| D[Use authenticated subject]
  C -->|No, deployed execution| E[Bind compatibility actor]
  D --> F[Principal-based workspace authorization]
  E --> F
  F --> G[Application operation]
  G --> H[Personal resource lookup using execution user]
  G --> I[Audit identity using principal]
Loading

Reviews (2): Last reviewed commit: "fix(auth): bind legacy execution actors ..." | Re-trigger Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot]
greptile-apps Bot reviewed Aug 28, 2026
View reviewed changes
Comment thread apps/sim/lib/credentials/application/authorization.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Aug 28, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 38 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread apps/sim/lib/credentials/application/credential-crud.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread apps/sim/lib/workflows/application/deployments.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
TheodoreSpeaks added 2 commits August 28, 2026 14:07
@TheodoreSpeaks
fix(executor): preserve actors for actorless tool calls
1aa7db8
@TheodoreSpeaks
fix(auth): bind legacy execution actors to principals
53c24fc
@TheodoreSpeaks
TheodoreSpeaks force-pushed the fix/cred-list-require-user branch from 5798075 to 53c24fc Compare August 28, 2026 21:13
@vercel
vercel Bot temporarily deployed to Preview August 28, 2026 21:13 Inactive
@TheodoreSpeaks

TheodoreSpeaks commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

@greptile
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@TheodoreSpeaks
TheodoreSpeaks merged commit acc4f1d into staging Aug 28, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/cred-list-require-user branch August 28, 2026 22:21
@waleedlatif1 waleedlatif1 mentioned this pull request Aug 28, 2026
v0.8.16: aws lambda, dynamics 365, actorless run fixes, usage chart #7224
Merged

This branch was previously deployed

1 inactive deployment
Preview — 53c24fc6 Deployed Aug 28, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@TheodoreSpeaks
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.