GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(docs): render the FAQ JSON-LD as a native script tag, and forbid data-typed next/script by waleedlatif1 · Pull Request #8875 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Render the docs FAQ JSON-LD as a native <script type='application/ld+json'>. next/script (default afterInteractive) renders nothing on the server and injects from an effect, so the FAQPage structured data never reached the served HTML — same bug and same fix as 025ea4d / 5da48d0
  • Extend check:source-text (already in check:audits) to fail on any next/script element in apps/** whose static type isn't JavaScript, so this can't ship a fourth time. The message points at the native-script + serializeJsonLd pattern

Type of Change

  • Bug fix

Testing

  • bun run scripts/check-source-text.ts passes on this branch; with the pre-fix faq.tsx it fails at faq.tsx:94, and with the pre-025ea4d2bd structured-data.tsx it fails at its three JSON-LD sites
  • Audited the other next/script uses in apps/sim and apps/docs — all load external JS via src, none affected
  • Full audits, lint, type-check and docs build run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
fix(docs): render the FAQ JSON-LD as a native script tag, and forbid …
68e5bd1 
…data-typed next/script

The FAQ component rendered its FAQPage JSON-LD through next/script with the
default afterInteractive strategy, which returns null on the server and injects
the tag from a client effect, so the served HTML never carried it. Render a
native <script> the way #6763 fixed the other docs JSON-LD blocks;
serializeJsonLd already escapes '<'.

check:source-text now also fails on a next/script element in apps/** whose type
is not JavaScript, naming the native-script fix.
@vercel

vercel Bot commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 10, 2026 2:24am UTC

Request Review
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] No separate new issue was found that blocks merging.

Summary

The PR renders FAQ JSON-LD with a native <script> and adds a source audit for data-typed next/script elements.

  • The docs FAQ puts its JSON-LD in the HTML served to crawlers.
  • The source-text audit rejects data-typed next/script elements in app source.

Reviews (4) · Last reviewed commit: "fix(audits): keep JSX template literals ..." · Reviewed by Greptile
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot]
greptile-apps Bot reviewed Oct 10, 2026
View reviewed changes
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vercel
vercel Bot deployed to Preview October 10, 2026 02:07
View deployment
@waleedlatif1
fix(audits): match only the real type prop, fail closed on expression…
3eb8131 
… types, and scan MDX pages
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR
cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
greptile-apps[bot]
greptile-apps Bot reviewed Oct 10, 2026
View reviewed changes
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
fix(audits): recognize default-as next/script imports and skip MDX co…
c4f55aa 
…de examples
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR
cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
greptile-apps[bot]
greptile-apps Bot reviewed Oct 10, 2026
View reviewed changes
Comment thread scripts/check-source-text.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
fix(audits): keep JSX template literals intact when skipping MDX inli…
765cda1 
…ne code
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile
greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1

waleedlatif1 commented Oct 10, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR
cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cubic-dev-ai

cubic-dev-ai Bot commented Oct 10, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 10, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vercel
vercel Bot deployed to Preview October 10, 2026 02:24
View deployment
@waleedlatif1
waleedlatif1 merged commit e526a91 into staging Oct 10, 2026
48 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@waleedlatif1
waleedlatif1 deleted the fix/guardrails-docs branch October 10, 2026 03:44

This branch was successfully deployed

1 active deployment
Preview — 765cda1a Deployed Oct 10, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.