GeezerVison is showing github.com — fix(scripts): normalize Windows path separators in validation scripts by sahooarnav2007-gif · Pull Request #9400 · simstudioai/sim
Conversation
Summary
Normalizes path separators in scripts/check-tool-registry-boundary.ts and scripts/check-api-validation-contracts.ts to ensure consistent cross-platform execution on Windows environments.
Problems Resolved:
check-tool-registry-boundary.ts: collectEntries() emitted relative paths with Windows backslashes (\), causing all 85 entries to fail comparison against check-tool-registry-boundary.baseline.json as unbaselined/removed.check-api-validation-contracts.ts: INDIRECT_ZOD_ROUTES.has(relativePath) failed for all 55 exempted routes due to backslash paths, falsely reporting non-Zod routes increased from 0 to 55. In addition, routeFamily() prefix stripping and isApiRouteHandler() / isClientHookFile() failed when comparing POSIX paths against Windows directory paths.
Product update (if relevant)
N/A — Developer tooling and CI verification fix for Windows environments.
Type of Change
- Bug fix
- New feature
- Breaking change
- Documentation
- Other: _____
Testing
- Verified
bun run check:tool-registry-boundary on Windows: passes cleanly with all 85 entry graphs matching baseline.
- Verified
bun run check:api-validation on Windows: passes cleanly with 895/895 Zod-backed routes and 0 non-Zod routes.
- Verified code style and formatting with
bunx biome check.
Checklist
- Code follows project style guidelines
- Self reviewed my changes
- Tests added/updated and passing
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Screenshots/Videos
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
|
Someone is attempting to deploy a commit to the Sim Team on Vercel.
A member of the Team first needs to authorize it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
  Confidence Score: 5/5
[Low impact] The PR appears safe to merge.
Summary
This PR makes path comparisons consistent on Windows in two validation scripts.
- The API validation check uses forward slashes when matching routes and folders.
- The registry boundary check writes discovered entry names with forward slashes.
No actionable issues found. This review checked the code paths; it did not run the scripts on Windows.
Reviews (1) · Last reviewed commit: "fix(scripts): normalize Windows path sep..." · Reviewed by Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
