GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(deps): upgrade better-auth to 1.7.12 by waleedlatif1 · Pull Request #9465 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

Moves better-auth, @better-auth/oauth-provider, @better-auth/sso, @better-auth/stripe (and packages/auth) from 1.6.27 to 1.7.12. 1.7.7+ fixes the magic-link, OAuth-proxy, device-authorization and DB rate-limit advisories (not reachable today, but 1.6 gets no fixes). Each 1.7 behavior change Sim depends on is adapted, following the 1.7 upgrade guide.

Dependencies

  • @better-auth/core calls z.validate (zod 4.5+); the root override keeps zod at 4.3.6, so every sign-in would throw. Version-pinned patch restores 1.6's safeParse form (documented in patches/README.md)
  • Dropped the global @xmldom/xmldom 0.8.15 override: sso 1.7 needs 0.9.12 (onError), while samlify/xml-crypto/mammoth/officeparser/plist keep 0.8.15 (0.9 throws without a MIME type)
  • Removed the obsolete oauth-provider 1.6.27 resource patch

Social sign-in

  • Microsoft accounts stay keyed by the ID token's sub: 1.7's provider keys by oid, so every existing Microsoft user would miss their account and fall to email linking, which Microsoft passes only for verified domains (account_not_linked)

Integration connectors (generic OAuth lost its /oauth2/* endpoints)

  • Registered /api/auth/oauth2/callback/:id URIs are forwarded to core /callback/:id — no provider re-registration
  • Client links via linkSocial; custom getToken keeps the registered redirect URI; Google connectors use explicit endpoints instead of discovery; scope rewrites moved into the token exchange; reserved authorize params (scope, nonce) passed as options; pkce: false kept explicit where 1.6 had it off
  • Connector callbacks only complete an authenticated link and never sign up/in a user (core doesn't bind state to a provider, so a replayed sign-in state could otherwise sign in whoever owns the email a connector reports)
  • Account hooks identify connector callbacks by the account's provider — hook contexts carry the route pattern, so the old path check would have skipped credential creation

MCP OAuth provider

  • Dynamic resources stay out of 1.7's static resource model via a signed sim_resource param
  • Public clients recognized by token_endpoint_auth_method: none (1.7 dropped public); registration infers app type so loopback/cursor:// callbacks still register; requested scopes are kept; a dpop_jkt is dropped (bearer tokens only, as in 1.6); metadata advertises only what Sim honors; tokens revoked at sign-out are rejected
  • Confidential clients keep their Basic credentials on the way to Better Auth: 1.7 refuses a client_secret_basic client whose credentials arrive in the body
  • Migration 0448: expand-only columns/tables, so 1.6 and 1.7 pods share the schema during rollout; the live OAuth tables are altered after the embedded COMMIT, one autocommitted statement each, so a token insert (which locks its own table before its FK check reaches oauth_client) cannot deadlock the deploy; runtime schema validation off in the app and the realtime verifier (migrations own the schema)

Enterprise SSO

  • Legacy SAML ACS URL forwarded to /sso/saml2/sp/acs/:id (POST and GET), so IdPs need no change; new providers advertise the new URL
  • IdP-initiated SAML (app-portal launches) stays allowed; 1.7 turns it off by default
  • Registration matches 1.7's strict schemas (no mapping.id; idpMetadata as metadata or entityID) and checks 1.7's sign-in policy on save
  • Migration 0449 (data, idempotent): writes entityID for cert-only providers, and clears wantAssertionsSigned where SP metadata never asked for signed assertions — keeping 1.6's accept-any-IdP-signature policy so IdPs that sign only the Response keep working; and drops an audience equal to the IdP's own entity ID (the registration script's old default), since 1.7 checks audience exclusively where 1.6 also accepted the SP entity ID
  • POST sign-in/email-otp refused: 1.7 deletes every linked account of an unverified user there

Behavior changes to expect

  • In-flight OAuth/SSO/MCP authorizations that span the 1.6→1.7 cutover fail once (state key format changed); retry works
  • SSO account ids now always come from OIDC sub / SAML NameID; providers that mapped another id claim re-link by email on their verified domain (new account row, same user)
  • OIDC SSO ID tokens are now always verified, so the stored issuer must match iss exactly
  • Browser sign-out revokes session-bound MCP access tokens; refresh tokens (offline_access) survive

Type of Change

  • Dependency update / security

Testing

  • Unit/route tests for every touched area: ~3,000 tests across auth, SSO, OAuth, credentials, credential groups, contracts
  • Microsoft sign-in integration: an existing sub-keyed account signs in through the real auth handler with no duplicate link (lands on account_not_linked without the fix)
  • Migration 0448 against 8 concurrent token-insert clients on Postgres 17: the previous file deadlocked in 5 of 6 runs (migration failed with 40P01); this one completes 6/6 with no failed inserts, and replays cleanly
  • Token route integration covers code exchange + refresh for client_secret_basic and client_secret_post clients (the Basic case fails on the previous code)
  • 17 auth-related integration files on disposable Postgres with all migrations (189 tests): token route, provider lifecycle, token family, lifecycle audit, SSO settings/admission/concurrency/primary provider, credential groups, reconnect conflict, credential revocation, shopify. The reconnect test caught the hook-path issue above
  • Migration 0449 run twice on fixture rows (cert-only, XML, already-strict, legacy string, bad JSON, non-object, OIDC, audience = IdP issuer / entity ID / SP / custom): correct and idempotent
  • drizzle-kit generate clean, check:migrations, biome; full type-check and audits run in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
waleedlatif1 requested a review from a team as a code owner October 30, 2026 04:01
@vercel

vercel Bot commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 31, 2026 3:59am UTC

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Critical impact] The changes since the previous review appear safe to merge.

Summary

Upgrades Better Auth to 1.7.12 and adapts connector linking, MCP OAuth, Microsoft sign-in, SSO, and database migrations.

  • OAuth connectors link accounts through Better Auth’s shared social sign-in flow.
  • MCP clients keep Sim’s dynamic resource audience through OAuth authorization and token exchange.
  • Enterprise SSO keeps saved providers working with Better Auth’s updated identity rules.
  • Sim’s shared auth setup and dependencies move to Better Auth 1.7.12.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Connector[Connector link] --> Core[Better Auth core callback]
  Legacy[Legacy SAML callback] --> ACS[SAML ACS endpoint]
  MCP[MCP authorization] --> Signed[Signed resource parameter]
  Signed --> Tokens[Resource-bound bearer tokens]
  Migration[Expand-only migrations] --> Database[(Shared database)]
  Core --> Database
  ACS --> Database
  Tokens --> Database
Loading

Reviews (9) · Last reviewed commit: "docs(sso): record the AD FS ACS example ..." · Reviewed by Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot temporarily deployed to Preview October 30, 2026 04:07 Inactive
greptile-apps[bot]
greptile-apps Bot reviewed Oct 30, 2026
View reviewed changes
Comment thread packages/db/migrations/0449_sso_saml_signin_authority.sql Resolved

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 30, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

This PR changes authentication, authorization, or input validation. Ultrareviews find 2.4x more serious bugs than standard reviews. Comment @cubic-dev-ai ultrareview to run one.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread apps/sim/lib/auth/sso/application/provider-registration.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/db/scripts/register-sso-provider.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/hooks/queries/oauth/connections.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/app/desktop/connect/connect-launcher.tsx Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/db/migrations/0448_sso_saml_signin_authority.sql Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/lib/auth/sso/provider-repository.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/db/scripts/register-sso-provider.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread packages/db/migrations/0449_sso_saml_signin_authority.sql Resolved

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 30, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 77 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot temporarily deployed to Preview October 30, 2026 04:32 Inactive
@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 30, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 77 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@waleedlatif1
waleedlatif1 force-pushed the chore/better-auth-1-7 branch from 5ba954d to f403950 Compare October 30, 2026 06:45
@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 30, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 82 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vercel
vercel Bot deployed to Preview October 30, 2026 06:52
View deployment
waleedlatif1 added 7 commits October 30, 2026 19:59
@waleedlatif1
chore(deps): upgrade better-auth to 1.7.12
5e7039f
Moves better-auth, @better-auth/oauth-provider, @better-auth/sso and
@better-auth/stripe (and packages/auth) from 1.6.27 to 1.7.12, which carries
the 1.7.7 fixes for the magic-link, OAuth proxy, device-authorization and
rate-limit advisories. Each place 1.7 changes behavior Sim relies on is adapted
so connects, sign-ins, the MCP OAuth provider and enterprise SSO keep working.

Dependencies
- @better-auth/core calls z.validate, added in zod 4.5; the root override keeps
  zod on 4.3.6, so a version-pinned patch restores 1.6's safeParse form.
- The global @xmldom/xmldom 0.8.15 override is dropped: @better-auth/sso needs
  0.9.12, and samlify, xml-crypto, mammoth, officeparser and plist keep 0.8.15.
- The oauth-provider 1.6.27 resource patch is obsolete and removed.

Integration connectors
- Generic OAuth no longer serves /oauth2/*; the registered
  /api/auth/oauth2/callback/:id URIs are forwarded to core's /callback/:id, so
  no provider registration changes. Clients link through linkSocial.
- Custom getToken uses the registered redirect URI; Google connectors use
  explicit endpoints instead of discovery; scope rewrites move into the token
  exchange; reserved authorization params (scope, nonce) are passed as options;
  pkce stays off where it was off.
- Connector callbacks only complete an authenticated link and never sign up or
  sign in a user; linking counts the profile email as verified.
- Account hooks identify connector callbacks by the account's provider, since
  hook contexts carry the route pattern.

MCP OAuth provider
- Resources stay out of 1.7's static resource model via a signed sim_resource
  parameter; public clients are recognized by token_endpoint_auth_method none;
  dynamic registration infers the application type; registrations keep their
  requested scopes; DPoP is refused and metadata advertises only what Sim
  honors; access tokens revoked at sign-out are rejected.
- Migration 0447 adds 1.7's columns and tables expand-only, so 1.6 and 1.7 pods
  share the schema during rollout. Runtime schema validation is off because
  migrations own Sim's schema.

Enterprise SSO
- The legacy SAML ACS URL is forwarded to /sso/saml2/sp/acs/:id, so IdPs need
  no change; new providers advertise the new URL.
- Registration matches 1.7's strict schemas (no mapping.id; idpMetadata as
  metadata or entityID) and checks 1.7's sign-in policy on save.
- Migration 0448 spells out entityID for certificate-only providers and clears
  wantAssertionsSigned where the SP metadata never asked for signed
  assertions, keeping 1.6's accept-any-IdP-signature policy.
- POST sign-in/email-otp is refused: 1.7 deletes every linked account of an
  unverified user there.
@waleedlatif1
chore(deps): shrink the explicit-any baseline for connector providers
7293f7a
@waleedlatif1
fix(auth): type the SSO token-auth selector against 1.7's config and …
49c813a
…the new test calls
@waleedlatif1
chore(deps): shrink the test-types baseline for the auth catch-all ro…
8b3fd37
…ute test
@waleedlatif1
fix(auth): address review on SSO registration, link start errors, and…
ae4e5cb
… migration 0448

- Keep the SSO plugin's parsed registration body, as before 1.7.
- Compare issuers exactly when carrying over a token auth method.
- Surface linkSocial start errors in the connect hook and desktop launcher.
- Accept whitespace around WantAssertionsSigned in migration 0448 and the script.
- The register script refuses custom SP metadata that contradicts its signing
  flag and prints the stored SAML ACS URL.
@waleedlatif1
fix(auth): clean up replayed authorization-code grants without strand…
8283ede
…ing token families

Better Auth 1.7 revokes a replayed code's tokens by authorizationCodeId outside
any transaction. The adapter guard now deletes the grant's token families
(cascading to its tokens) and refuses an access-token insert whose refresh
token a concurrent replay already removed as invalid_grant instead of a 500.
@waleedlatif1
fix(auth): keep confidential OAuth clients, IdP-launched SAML, and sc…
6e554b9
…ript SAML audiences working on Better Auth 1.7

- Forward a client's Basic credentials to Better Auth unchanged; 1.7 decodes them itself and refuses a client_secret_basic client that arrives through the body
- Drop a client's dpop_jkt instead of refusing the authorization request, matching 1.6, since Sim issues bearer tokens only
- Allow IdP-initiated SAML, which 1.7 turns off by default; correct the docs that said it was rejected
- Migration 0448 drops a SAML audience equal to the IdP's own entity ID (the registration script's old default), which 1.7 now enforces exclusively; the script now leaves audience unset
- Order migration 0447's ALTERs the way token issuance locks the tables
- Turn off Better Auth's runtime schema check in the realtime one-time-token verifier
- Share one issuer normalizer across SSO, accept either quote in WantAssertionsSigned, and tidy comments
@waleedlatif1
waleedlatif1 force-pushed the chore/better-auth-1-7 branch from f403950 to 6e554b9 Compare October 31, 2026 02:59
@vercel
vercel Bot deployed to Preview October 31, 2026 03:08
View deployment
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot temporarily deployed to Preview October 31, 2026 03:28 Inactive
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
chore(db): format the regenerated 0448 and 0449 snapshots
5b72337
@waleedlatif1
waleedlatif1 force-pushed the chore/better-auth-1-7 branch from 2ad4c83 to 5b72337 Compare October 31, 2026 03:28
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot temporarily deployed to Preview October 31, 2026 03:28 Inactive
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Oct 31, 2026
View reviewed changes
Comment thread apps/sim/app/api/auth/oauth2/token/route.integration.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Oct 31, 2026
View reviewed changes
Comment thread apps/sim/app/api/auth/oauth2/token/route.integration.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Oct 31, 2026
View reviewed changes
Comment thread apps/sim/app/api/auth/oauth2/token/route.integration.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 85 files

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread apps/docs/openapi-v2-resources.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
fix(auth): address review on test randomness, the SSO callbackUrl def…
066bedf
…ault, and an unused type export
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 85 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vercel
vercel Bot deployed to Preview October 31, 2026 03:42
View deployment
@waleedlatif1
docs(sso): record the AD FS ACS example in the docs migration baseline
bf3f6b7
@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Oct 31, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 87 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vercel
vercel Bot deployed to Preview October 31, 2026 03:59
View deployment
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 9, 2026
chore(deps): take the Next.js 16.4.5 security release, patch node-gyp's undici, and refresh in-range patches #9819
Merged
7 tasks done

This branch was successfully deployed

1 active deployment
Preview — bf3f6b79 Deployed Oct 31, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.