GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(table): add Columns to Return to the legacy Table block's Query Rows by waleedlatif1 · Pull Request #9887 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • The legacy Table block (table, superseded by table_v2) now has the same Columns to Return picker as table_v2. Existing workflows still run on the legacy block, and the upgrade is a Copilot-assisted rewrite rather than an automatic one.
  • A query that leaves it empty behaves exactly as before. With columns selected, each returned row's data keeps only those columns, so large cells a workflow never reads no longer land in its execution data or count against the 5 MiB row-data budget.
  • Wiring only, reusing the existing projection in queryTableRows:
    • table_query_rows takes an optional columns param, sent as a JSON query value.
    • The internal listTableRowsContract accepts columns, and both the GET rows route and executeTableQueryRows pass it through. The shared tableRowsQueryBaseSchema that the public v1/v2 APIs extend is unchanged.
    • The column-reference schema is extracted and shared with the v2 query body contract.
  • The "Columns to Return" field, its input, and the parser (canvas selection first, a model-supplied columns as the fallback, fail fast on malformed values) now live in blocks/utils.ts, shared by both Table blocks. A malformed-JSON error now reads "Invalid JSON for Columns to Return" (was "in"), from the shared parseOptionalJsonInput.

Type of Change

  • New feature (backward compatible)

Testing

  • New tests, each shown red by reverting its part of the change (contract field, tool serialization, block mapping):
    • execute-tool.test.ts runs the real v1 tool serialization through the real contract decoding into the operation.
    • A legacy block transformer case in table.test.ts.
  • Ran execute-tool.test.ts, table.test.ts, table_v2.test.ts, operations.test.ts, the rows route.test.ts, query_rows_v2.test.ts and blocks/utils.test.ts: 55 passed.
  • Ran bun run lint, check-block-registry.ts origin/staging, check:api-validation:strict, check:explicit-any, check:client-boundary, check:tool-registry-boundary, check:utils and check:comment-hygiene. generate:tool-metadata was regenerated.
  • bun run type-check (pre-push hook) passes; check:audits and the full test suite are left to CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waleedlatif1
feat(table): add Columns to Return to the legacy Table block's Query …
174ea53
…Rows
@vercel

vercel Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 11, 2026 8:29pm UTC

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; stale selections no longer return excluded fields.

Summary

Adds Columns to Return to the legacy Table block’s Query Rows operation.

  • Legacy Table queries can return only the columns you choose.

No new actionable issues were found in the changes since the previous review. Tests were not run during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Legacy Table picker] --> B[Shared selection parser]
  B --> C[table_query_rows]
  C --> D[Internal query contract]
  D --> E[queryTableRows]
  E --> F[Rows with selected data]
Loading

Reviews (3) · Last reviewed commit: "Revert "fix(table): treat a column selec..." · Reviewed by Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 11, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 12 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread apps/sim/lib/api/contracts/tables.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
fix(table): treat a column selection with no resolvable columns as al…
1b59b12
…l columns
@waleedlatif1

waleedlatif1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vercel
vercel Bot temporarily deployed to Preview November 11, 2026 20:18 Inactive
@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 11, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
greptile-apps[bot]
greptile-apps Bot reviewed Nov 11, 2026
View reviewed changes
Comment thread apps/sim/lib/table/application/rows.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
Revert "fix(table): treat a column selection with no resolvable colum…
77ae095
…ns as all columns"

This reverts commit 1b59b12.
@vercel
vercel Bot temporarily deployed to Preview November 11, 2026 20:29 Inactive
@waleedlatif1

waleedlatif1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 11, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 12 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@waleedlatif1
waleedlatif1 merged commit e675e62 into staging Nov 11, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
waleedlatif1 deleted the feat/table-query-columns-sim34 branch November 11, 2026 20:34
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 12, 2026
v0.9.54: non-OAuth auth for twelve more integrations, agent API additions (workflow outline, schedules list, paused runs, scoped CLI pairing keys), concurrent-edit guard, dependency updates #9912
Merged

This branch was previously deployed

1 inactive deployment
Preview — 77ae0957 Deployed Nov 11, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.