GeezerVison

Summary

• Follow-up to fix(http): stop treating 200 bodies with status and data keys as proxy responses #9889 (issue [BUG] http_request / webhook_request report a successful HTTP 200 as failed when the JSON body has top-level status and data keys #9838). Deleting the old /api/proxy envelope branch fixed JSend-style 200s, but it also changed two behaviors existing API/Webhook blocks have had since that route was removed:
  • a 200 body with success, status, and data was unwrapped, so <api.data.x> read the inner data
  • a 200 body with success: false failed the block with the body's error, so error branches ran
• Restores both through one shared toHttpToolResponse helper in tools/http/utils.ts, gated on the body carrying a success field — the only shape the old route ever produced (success: response.ok). A body without it (JSend {status, data}) stays an ordinary response, which is the [BUG] http_request / webhook_request report a successful HTTP 200 as failed when the JSON body has top-level status and data keys #9838 fix
• Net effect vs. before fix(http): stop treating 200 bodies with status and data keys as proxy responses #9889: only bodies with no success field change. Non-string envelope errors are now JSON-serialized instead of reaching the caller as an object ([object Object] in the API block)
• Both tools share the helper, which also drops their duplicated header-copy loops

Type of Change

• Bug fix

Testing

• tools/index.test.ts: both real tools through executeTool for JSend, success: true unwrap, and success: false with string and object errors. Red on fix(http): stop treating 200 bodies with status and data keys as proxy responses #9889 as merged (6 compat cases), red on pre-fix(http): stop treating 200 bodies with status and data keys as proxy responses #9889 code only for the JSend case and the object-error serialization, green with this change
• bunx vitest run tools/index.test.ts tools/http executor/handlers/api (284 passed), biome, check:utils, check:test-patterns, check:comment-hygiene; full gate in CI

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)