GeezerVison is showing github.com — fix(security): refuse an extra slash after https:// in typed base URLs by waleedlatif1 · Pull Request #9913 · simstudioai/sim
Conversation
Summary
refuseUnsafeUrlForm now refuses a slash or backslash right after http(s)://. The URL parser skips those, so https:///user:pass@host slipped past refuseUnsafeTypedUrl's authority check and a caller's normalizer silently dropped the credentials
- Both
normalizeHttpBaseUrl and refuseUnsafeTypedUrl inherit it (GitLab, ServiceNow, Infisical, EmailBison, Jupyter, Logfire and the other typed-host validators)
- A bare
host:port such as ftp:123 is unchanged: every caller prefixes https://, so it stays a host and port
Type of Change
Testing
input-validation.test.ts: two new cases fail on the old guard and pass now (141 passing)
- Caller suites: token-service-accounts validators, Infisical, EmailBison, Jupyter (264 passing)
- biome on the changed files; CI runs type-check and audits
Checklist
- Code follows project style guidelines
- Self-reviewed my changes
- Tests added/updated and passing (new tests pass the
test-audit authoring gate)
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
| Project |
Deployment |
Actions |
Updated |
docs |
Skipped |
|
Nov 12, 2026 12:39am UTC |

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Turn on auto-fix | Re-trigger cubic
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
 Confidence Score: 5/5
[Medium impact] This PR appears safe to merge.
Summary
This PR rejects an extra slash or backslash immediately after http(s):// in typed base URLs.
- Typed base URLs with an extra separator after HTTP(S) are refused.
Reviews (1) · Last reviewed commit: "fix(security): refuse an extra slash aft..." · Reviewed by Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This branch was previously deployed
1 inactive
deployment
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|