GeezerVison is showing github.com — improvement(table): document that a column selection matching no column returns empty row data by waleedlatif1 · Pull Request #9915 · simstudioai/sim
Conversation
Summary
- Clarifies the documented
columns contract for row queries. A reference that matches no column is ignored, and if none match, each row's data is empty. The old wording ("a reference that matches no column is ignored") could be read as falling back to every column when nothing matches.
- No behavior change. Failing closed is intentional: widening a stale selection to every column would return cells the caller deliberately excluded. This behavior is already live for the v2 query API.
- The two row-query tools (
table_query_rows, table_query_rows_v2) now share one TABLE_COLUMNS_PARAM in tools/table/params.ts, following TABLE_ID_PARAM, so their parameter descriptions can't drift apart. The contract description (rowColumnSelectionSchema) stays separate because it documents the API field.
- Regenerated
tool-metadata.ts and the Table integration docs page.
Type of Change
- Documentation / improvement (no behavior change)
Testing
- Ran the table tool and internal table operation suites (
tools/table, lib/internal/table, the table block tests, lib/api/contracts): all pass.
- Ran
check:docs, check:api-validation:strict and check:comment-hygiene. The pre-push lint:check and type-check pass.
Checklist
- Code follows project style guidelines
- Self-reviewed my changes
- Tests added/updated and passing (new tests pass the
test-audit authoring gate)
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
…mn returns empty row data
vercel
Bot
commented
Nov 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
 Confidence Score: 5/5
[Low impact] This PR appears safe to merge; the clarified descriptions match the existing query behavior.
Summary
Clarifies that a nonempty columns selection matching no column returns empty row data.
- Row-query docs explain what happens when no selected columns match.
Reviews (1) · Last reviewed commit: "improvement(table): document that a colu..." · Reviewed by Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cubic-dev-ai
Bot
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This branch was successfully deployed
1 active
deployment
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|