GeezerVison is showing github.com — feat(aws-marketplace): gate Enterprise on the AWS Marketplace container license and add the EKS install profile by waleedlatif1 · Pull Request #9917 · simstudioai/sim
Conversation
Summary
- On a Marketplace install (
AWS_MARKETPLACE_LICENSE_PRODUCT_SKU set), the container entrypoint reads the buyer's AWS License Manager licenses for this product before the server loads, with ListReceivedLicenses filtered to the product SKU and the AWS Marketplace issuer fingerprint. A license that License Manager reports AVAILABLE and that carries the enterprise_license entitlement sets ENTERPRISE_ENABLED and its browser twin, so every existing Enterprise gate reads the answer unchanged
- The license is read, not checked out. A contract usually covers the deployment with one unit, so a checkout from every replica would make them compete for it, and a unit stuck after a failed check-in reads exactly like an expired license for an hour
- No license, or a check that can't reach License Manager, leaves Sim running as the open-source core. It never stops serving
- It re-checks every 15 minutes, the cadence AWS recommends for renewals, upgrades and cancellations. A definitive change (not a failed check) sends SIGTERM so Kubernetes restarts the pod in the right mode. Enterprise flags are read once at startup by the server and the browser, so a restart applies the change without rewriting any gate
- Nothing runs without the SKU env var, so other self-hosted and cloud deployments are unaffected
- New
examples/values-aws-marketplace.yaml, the EKS profile the Marketplace chart ships as its defaults:
- It runs only Sim's own images: app, realtime, migrations, and the
cron image for scheduled jobs in place of curlimages/curl.
- Bundled Postgres and Redis are off in favor of the buyer's RDS and ElastiCache, because AWS Marketplace hosts and scans every image a listing can deploy. The
helm test busybox hook is off for the same reason.
- Secrets come only from pre-created Kubernetes Secrets, never from values.
- The ServiceAccount is annotated for IRSA.
- New
examples/aws-marketplace-prerequisites.yaml, a CloudFormation template for the buyer's account:
- RDS for PostgreSQL 17, Multi-AZ and encrypted, with the master password managed in Secrets Manager.
- Valkey with TLS and a generated auth token.
- The IRSA role, allowed only
license-manager:ListReceivedLicenses.
@aws-sdk/client-license-manager 3.1162.0, the same version as the other AWS clients. It goes through awsRequestHandler, so HTTPS_PROXY is honored
Type of Change
Testing
helm lint and helm template with the new profile, alone and with ci/default-values.yaml, the way the chart CI renders every example. Rendered images are only simstudioai/{simstudio,realtime,migrations,cron}
aws cloudformation validate-template and cfn-lint pass. cfn-lint's only warning is the major-only EngineVersion: '17', kept on purpose so RDS picks the current minor
bun run lint, plus check:egress-boundary, check:source-conventions, check:utils, check:file-names, check:comment-hygiene, check:explicit-any and check:boundaries. The full audits, type-check and tests run in CI
- Chart version bumped to 1.11.15 for the chart-testing version check
- The end-to-end proof comes after release: subscribe from an allowlisted account, install on EKS from the Marketplace registry, and confirm the license read turns Enterprise on
Checklist
- Code follows project style guidelines
- Self-reviewed my changes
- Tests added/updated and passing (new tests pass the
test-audit authoring gate)
- No new warnings introduced
- I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
greptile-apps[bot] reacted with thumbs up emoji
…er license and add the EKS install profile
vercel
Bot
commented
Nov 12, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
 Confidence Score: 5/5
[High impact] The PR appears safe to merge; no new blocking issue was found.
Summary
Adds AWS Marketplace license checks before server startup and an EKS install profile backed by RDS and ElastiCache.
- AWS Marketplace licenses now set Enterprise mode before Sim starts.
- EKS Marketplace installs use Sim images and buyer-managed AWS services.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Boot[Container starts] --> Secrets[Load runtime secrets]
Secrets --> SKU{Marketplace SKU set?}
SKU -->|No| Server[Start server]
SKU -->|Yes| Read[Read received licenses]
Read --> Flags[Set Enterprise flags]
Flags --> Server
Flags --> Poll[Check every 15 minutes]
Poll --> Changed{Definitive answer changed?}
Changed -->|No or failed check| Poll
Changed -->|Yes| Restart[Send SIGTERM; Kubernetes restarts container]
Loading
Reviews (3) · Last reviewed commit: "docs(aws-marketplace): say where the pro..." · Reviewed by Greptile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
cubic-dev-ai
Bot
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 7 files
Confidence score: 2/5
container-license.ts lets any individual Enterprise feature flag bypass the Marketplace check, so unlicensed customers may get Enterprise features. Make Marketplace license state authoritative over those flags.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/billing/aws-marketplace/container-license.ts">
<violation number="1" location="apps/sim/lib/billing/aws-marketplace/container-license.ts:44">
P1: The Marketplace check can be bypassed by setting any individual Enterprise feature flag, because this change only disables the master switch and feature flags explicitly override it. Make Marketplace license state the entitlement source for every Enterprise feature, or reject/clear per-feature overrides when the SKU is configured.</violation>
</file>
Turn on auto-fix | Re-trigger cubic
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…, scope the IAM role to it, and bump the chart
greptile-apps[bot] reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cubic-dev-ai[bot] reacted with eyes emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cubic-dev-ai
Bot
left a comment
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…he RDS username tied to the template, and note why the license is read in the pod's Region
greptile-apps[bot] reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cubic-dev-ai[bot] reacted with eyes emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 8 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Turn on auto-fix | Re-trigger cubic
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|