GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(credentials): age-gate 403 token eviction and tidy the client-credential paths by waleedlatif1 · Pull Request #9918 · simstudioai/sim

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Summary

  • 403 eviction: an internal operation's 403 now drops this instance's cached client-credential token only when the token is at least 60s old. This is the same age gate the external-request path uses. Before, any 403 evicted a still-valid token, including Sim's own file-access refusals and per-record permission denials on providers such as DocuSign, so the next call minted a new token every time. A 401 still evicts immediately.
  • Failure backoff: documented that the coordinated token cache backs off for 30 seconds after any failed exchange, whether the provider refused the credentials or had an outage. This matches the per-instance mint cache and the Vanta chain, so the policy is the same at every layer. No behavior change.
  • Cleanups:
    • Removed redundant redirect: 'error' options, since fetchProvider already defaults to it.
    • The Zendesk saved token param uses the shared savedCredentialTokenParam helper.
    • The SailPoint minter takes its token URL from resolveSailPointHosts.
    • Corrected the TSDoc for SailPoint and HubSpot.

Type of Change

  • Bug fix

Testing

  • New behavioral tests, each red before the fix and green after:
    • The credential cache, on a fake clock, keeps a token refused at 30s and replaces one refused at 61s.
  • 1479 targeted tests pass across lib/credentials, credential-service, lib/internal/sailpoint, tools/index.test.ts and tools/zendesk.
  • bunx biome check, check:test-patterns, check:comment-hygiene, check:utils, check:explicit-any, check:tool-metadata and the pre-push type-check pass.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
waleedlatif1 added 2 commits November 11, 2026 17:08
@waleedlatif1
fix(credentials): age-gate 403 token eviction and stop memoizing tran…
110f604
…sient mint failures

An internal operation's 403 now drops this instance's cached client-credential
token only once it is older than a minute, matching the external-request path,
so a 403 from a file-access refusal or per-record permission no longer re-mints
on every call. The coordinated token's failure memo keeps only refusals of the
credentials themselves; provider_unavailable propagates with no memo row.
@waleedlatif1
chore(credentials): drop redundant redirect options and correct SailP…
8166d56
…oint and HubSpot docs

fetchProvider already refuses redirects by default. Zendesk's hidden token param
uses savedCredentialTokenParam, the SailPoint minter takes its token URL from
resolveSailPointHosts, and the SailPoint host and HubSpot fallback TSDoc now
match the code.
@vercel

vercel Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 12, 2026 1:21am UTC

Request Review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1 waleedlatif1 mentioned this pull request Nov 12, 2026
v0.9.54: non-OAuth auth for twelve more integrations, agent API additions (workflow outline, schedules list, paused runs, scoped CLI pairing keys), concurrent-edit guard, dependency updates #9912
Merged
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues remain.

Summary

Adds a 60-second age check before an internal operation’s 403 removes a cached token. A 401 still removes it immediately.

  • Internal 403s keep recently minted client-credential tokens.
  • SailPoint saved credentials get token URLs from the shared tenant resolver.
  • Credential requests and notes now reuse shared rules.

Reviews (2) · Last reviewed commit: "fix(credentials): keep the coordinated t..." · Reviewed by Greptile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

greptile-apps[bot]
greptile-apps Bot reviewed Nov 12, 2026
View reviewed changes
Comment thread apps/sim/lib/credentials/coordinated-client-token.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 12, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 16 files

Confidence score: 3/5

  • During rollout, decodeFailure in apps/sim/lib/credentials/coordinated-client-token.ts rejects unexpired legacy provider_unavailable memos, so resolution throws without calling input.exchange. Handle that legacy format or invalidate those memos.
Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/lib/credentials/coordinated-client-token.ts">

<violation number="1" location="apps/sim/lib/credentials/coordinated-client-token.ts:144">
P2: `decodeFailure` rejects the `provider_unavailable` rows written by the previous implementation as malformed. During rollout, an unexpired legacy memo makes resolution throw without calling `input.exchange`, so transient failures remain cached; ignore and delete legacy transient rows instead of treating them as fatal.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread apps/sim/lib/credentials/coordinated-client-token.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/lib/oauth/credential-service.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/lib/credentials/coordinated-client-token.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread apps/sim/lib/credentials/coordinated-client-token.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
fix(credentials): keep the coordinated token's 30-second backoff for …
4336f3e
…every failed exchange

Remembering only credential refusals in the shared row left the per-instance
mint cache and the Vanta chain still backing off on outages, so the policy
differed by layer. Keep the long-standing 30-second backoff everywhere and
document it.
@waleedlatif1 waleedlatif1 changed the title fix(credentials): age-gate 403 token eviction and stop memoizing transient mint failures fix(credentials): age-gate 403 token eviction and tidy the client-credential paths Nov 12, 2026
@vercel
vercel Bot temporarily deployed to Preview November 12, 2026 01:21 Inactive
@waleedlatif1

waleedlatif1 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

greptile-apps[bot] reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1

waleedlatif1 commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

cubic-dev-ai[bot] reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Nov 12, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 15 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@waleedlatif1
waleedlatif1 merged commit d26b61f into staging Nov 12, 2026
145 of 148 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@waleedlatif1
waleedlatif1 deleted the fix/credential-final-audit branch November 12, 2026 02:03

This branch was previously deployed

1 inactive deployment
Preview — 4336f3e5 Deployed Nov 12, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@waleedlatif1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.