GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: describe jsx transpilation by atk · Pull Request #1069 · solidjs/solid-docs

Conversation

@atk

@atk atk commented Feb 11, 2025

Copy link
Copy Markdown
Contributor
  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description(required)

The current docs are missing information on how solid works under the hood, especially the JSX transpilation. I aim to fill this gap with the current PR

Related issues & labels

./.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
incognitojam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@atk
feat: describe jsx transpilation
c6729b5
@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Feb 11, 2025

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@netlify

netlify Bot commented Feb 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

✅ Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit a4081c2
🔍 Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/67d72f07598bbf00084b0660
😎 Deploy Preview https://deploy-preview-1069--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kodiakhq Bot added 27 commits February 13, 2025 15:10
@kodiakhq
Merge branch 'main' into feat/how-it-works
613fa73
@kodiakhq
Merge branch 'main' into feat/how-it-works
87727cc
@kodiakhq
Merge branch 'main' into feat/how-it-works
a340d60
@kodiakhq
Merge branch 'main' into feat/how-it-works
838c3f1
@kodiakhq
Merge branch 'main' into feat/how-it-works
82be369
@kodiakhq
Merge branch 'main' into feat/how-it-works
ef09d99
@kodiakhq
Merge branch 'main' into feat/how-it-works
b7b321d
@kodiakhq
Merge branch 'main' into feat/how-it-works
65b6867
@kodiakhq
Merge branch 'main' into feat/how-it-works
57d8778
@kodiakhq
Merge branch 'main' into feat/how-it-works
2b8c817
@kodiakhq
Merge branch 'main' into feat/how-it-works
ee725a9
@kodiakhq
Merge branch 'main' into feat/how-it-works
1cd0d48
@kodiakhq
Merge branch 'main' into feat/how-it-works
5a3150c
@kodiakhq
Merge branch 'main' into feat/how-it-works
b23fdb7
@kodiakhq
Merge branch 'main' into feat/how-it-works
580f15f
@kodiakhq
Merge branch 'main' into feat/how-it-works
6713456
@kodiakhq
Merge branch 'main' into feat/how-it-works
c867fe1
@kodiakhq
Merge branch 'main' into feat/how-it-works
47fe5a4
@kodiakhq
Merge branch 'main' into feat/how-it-works
8fc4d02
@kodiakhq
Merge branch 'main' into feat/how-it-works
e4a0840
@kodiakhq
Merge branch 'main' into feat/how-it-works
dac0ddc
@kodiakhq
Merge branch 'main' into feat/how-it-works
7193ad8
@kodiakhq
Merge branch 'main' into feat/how-it-works
13708b4
@kodiakhq
Merge branch 'main' into feat/how-it-works
233cef1
@kodiakhq
Merge branch 'main' into feat/how-it-works
09a8064
@kodiakhq
Merge branch 'main' into feat/how-it-works
714d95b
@kodiakhq
Merge branch 'main' into feat/how-it-works
f482d90
@kodiakhq
Merge branch 'main' into feat/how-it-works
cea59f3
@LadyBluenotes
LadyBluenotes requested review from LadyBluenotes and amirhhashemi March 8, 2025 00:33
kodiakhq Bot added 6 commits March 8, 2025 00:34
@kodiakhq
Merge branch 'main' into feat/how-it-works
55eca12
@kodiakhq
Merge branch 'main' into feat/how-it-works
fcd2903
@kodiakhq
Merge branch 'main' into feat/how-it-works
6a571fa
@kodiakhq
Merge branch 'main' into feat/how-it-works
8f4131e
@kodiakhq
Merge branch 'main' into feat/how-it-works
faf5c66
@kodiakhq
Merge branch 'main' into feat/how-it-works
ec8e034
amirhhashemi
amirhhashemi reviewed Mar 16, 2025
View reviewed changes

@amirhhashemi amirhhashemi left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains a lot of valuable information about how Solid works. Nice job. However, I'm uncertain if it aligns well with our docs. Even in the advanced section, I think it's too technical to be useful to most people.

The section on Hyperscript is helpful for those who want to use Solid without a build step (there's an issue regarding this), but I would prefer to have a more practical guide about it.

If we had a blog, I would share this information there, as it would be a shame to lose it. Especially the information about custom renderers is interesting. Overall, I don't think this is a good fit for our docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kodiakhq Bot added 2 commits March 16, 2025 20:04
@kodiakhq
Merge branch 'main' into feat/how-it-works
2bf5319
@kodiakhq
Merge branch 'main' into feat/how-it-works
a4081c2
@brenelz

brenelz commented Aug 1, 2025

Copy link
Copy Markdown
Collaborator

What do we want to do with this pr?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@LadyBluenotes

LadyBluenotes commented Aug 1, 2025

Copy link
Copy Markdown
Member

Needs to be reviewed still. I haven't had the time and other people haven't been available to @brenelz
brenelz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@amirhhashemi

amirhhashemi commented Aug 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

I still don’t think this content is a good fit for our docs. The topics covered here feel way too advanced for most users. Unless someone is really interested in building a framework or digging deep into Solid, this page might just confuse them.

So, I suggest we close this PR and move the useful points (for average users) to other sections:

  • I noticed the createRenderer function isn’t documented yet. Tracked here.
  • After Solid 2.0, we should definitely document Hyperscript functions. Tracked here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atk

atk commented Aug 3, 2025

Copy link
Copy Markdown
Contributor Author

I really believe we should not leave these parts undocumented. I'll happily add a warning that these are advanced topics that are not required knowledge to use solid.js, but I am against leaving out content that might help advanced readers.

Meeting beginners is fine, ignoring advanced users is not.
everton-dgn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amirhhashemi amirhhashemi amirhhashemi left review comments
@LadyBluenotes LadyBluenotes Awaiting requested review from LadyBluenotes

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@atk @brenelz @LadyBluenotes @amirhhashemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.