GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Improve http client, Adhere LSP by dev-ruby · Pull Request #33 · solvedac/python

Conversation

@dev-ruby

@dev-ruby dev-ruby commented Apr 11, 2024

Copy link
Copy Markdown
Member

Changes

  • MakeHttpxHTTPClient, AiohttpHTTPClient follow AbstractHTTPClient
  • Delete unittest_github_action.py
  • Change http_library parameter to http_client in Client's constructor

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dev-ruby added 7 commits April 11, 2024 20:35
@dev-ruby
Delete unittest_github_action.py
0b23248
@dev-ruby
Add solvedac_token parameter to AbstractHTTPClient constructor
39147b3
@dev-ruby
Delete loop parameter in HttpxHTTPClient constructor
3a0e156
@dev-ruby
Delete loop parameter in AiohttpHTTPClient constructor
67ea06b
@dev-ruby
Improve get_http_client method, Remove HTTPClientLibrary enum
1328357
@dev-ruby
Remove HTTPClientLibrary from __all__
4af6c1e
@dev-ruby
Change http_library parameter to http_client
23b8089
@dev-ruby
dev-ruby merged commit bc938f6 into main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@dev-ruby
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.