GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fillet squash - add internal functions (no UI) for fillets and chamfers by phkahler · Pull Request #1815 · solvespace/solvespace

Conversation

@phkahler

@phkahler phkahler commented Nov 9, 2026

Copy link
Copy Markdown
Member

This adds functions to modify shell edges with either a fillet or chamfer but no UI to do so.

The PR is broken into two commits - one that has changes to existing files which could be independent. And one that brings in the new functions in a couple new files.

@ruevs I normally wouldn't want to merge a WIP feature like this, but I think the fillet functionality is at a good stopping point. It lies almost entirely in new files, and you can even build with it without it being called. I'd like to spend some time working on some internals we will need to pass edge selections down to the NURBS code, and it will be easier with this part on master. I understand if you say NO loudly since it's incomplete.

Another reason for this: People have already done this with OCCT, so maybe they would like to try with a built-in capability.

All you need to do to test it is uncomment line 418 in groupmesh.cpp which reads:

       // runningShell.ModifyEdges();

Then go into chamfer.cpp line 296 and change the return value from this function:

double SShell::GetEdgeModifier(SCurve &) {
    return 0.0;
}

Have it return a radius in mm. It will then try to apply that radius to every edge on your shell. This will probably be bad to do with multiple groups, since priors will already have them. The correct way to connect the UI is through that function - it will need to determine which edges a user has selected for rounding and what size. BTW make the return negative to get fillets.

You can try checking coordinates of a curve and only modifying say the top of a text extrusion. But this is in no way a useful modeling tool without a proper UI.

My next steps will be in establishing correct tagging of shell edges with the handle of the entity that created them, or was generated on top of them. That will give us mapping from selectable entities to shell edges. Still not UI, but a step closer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
phkahler added 2 commits November 8, 2026 19:03
@phkahler
Add SBezier::Reparameterized(), which gives the same curve over a new…
b6ab118
… parameter range, extending or shortening it; it works in homogeneous coordinates, so rational curves stay exact. Fix SSurface::ClosestPointTo() for planes whose u and v directions aren't perpendicular, and the clip of a plane-plane intersection line to the planes' (u, v) range in the same case: both now use the dual basis of the two directions.
@phkahler
Fillet and chamfer edges of NURBS shells.
26e22a0
New edge modifier, SShell::ModifyEdges(), in src/srf/chamfer.cpp, with
sphere patches for corners in src/srf/sphere_patch.cpp. Fillets and chamfers
are built from the rolling ball's cross-section between faces at any angle,
on straight, arc, quadratic and cubic edges (quadratics and cubics are split
in 2 and offset piece by piece), along tangent chains, at three-edge corners
(flat triangle or sphere patch), with miters at reflex corners, and ending
on flat or curved end faces. Traced pieces use
SSurface::MarchIntersection(). Edges that can't be done are left out and
the rest are filleted. The design and its limits are described at the top
of chamfer.cpp.

Not active yet: SShell::GetEdgeModifier() picks no edges, and the call to
ModifyEdges() in Group::GenerateShellAndMesh() is commented out, until edges
can be picked in the user interface.
@phkahler phkahler mentioned this pull request Nov 9, 2026
WIP add functions for creating chamfers and fillets to the NURBS kernel #1501
Closed
ruevs
ruevs requested changes Nov 9, 2026
View reviewed changes

@ruevs ruevs left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phkahler how would it help you if this was on master?
As for merging it:

  • "+" It's fairly unobtrusive
  • "-" It's totally not ready
    • No inside fillets/chamfers
      • Image
      • Image
    • This beautiful monster (body smaller than the fillets) Image

By the way the beautiful monster may be a decent way to fail (it's pretty obvious) instead of trying to detect it (it will be complicated) and somehow explain the problem to the user.

Bottom line - this a good start but is too unfinished - in my opinion it should live on a branch for now.

That said, if you have a very good reason why it should go into master please let me know.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/srf/ratpoly.cpp
Vector dp = p.Minus(orig);
*u = dp.Dot(bu) / tx.MagSquared();
*v = dp.Dot(bv) / ty.MagSquared();
*u = dp.Dot(tx) / tx.MagSquared();

@ruevs ruevs Nov 9, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey you picked up the fix from #1812 :-)
0c63d8c#diff-9a3c0518824c807f35571bba5775d312f07c78f39e153ef725d3163f47e07bcaR537

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread src/srf/surfinter.cpp
s->ClosestPointTo(p, &up, &vp);
ud = (dl.Dot(tu)) / tu.MagSquared();
vd = (dl.Dot(tv)) / tv.MagSquared();
ud = (dl.Dot(tx)) / tx.MagSquared();

@ruevs ruevs Nov 9, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha - one more spot -the same bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@phkahler

phkahler commented Nov 9, 2026

Copy link
Copy Markdown
Member Author

@ruevs I think I'm just being a bit paranoid about keeping it on my machine, and also having it become hard to merge later. But as this squash shows, very little of master is touched, and by putting that in a separate commit it should remain easy to merge. I'll probably create a branch for it.

As for your models. When a fillet in a chain fails, it tends to propagate to the entire chain. So your complex intersections are causing the entire groups not to fillet. In practice one should usually wait and apply them all once the main geometry is done. You could make something with a flat top and bottom and extrude union or difference through that. Interior fillets definitely do work, but where concave and convex meet at a vertex it will fail - not sure how many of them will fail.

Anyway, a branch it shall be. I need to get the UI working so we can more easily make specific test cases.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruevs ruevs ruevs requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@phkahler @ruevs
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.