GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix/redis: set Redis endpoints on the code-intel workers by marcleblanc2 · Pull Request #1004 · sourcegraph/deploy-sourcegraph-helm

Conversation

@marcleblanc2

@marcleblanc2 marcleblanc2 commented Nov 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

precise-code-intel-worker and syntactic-code-intel-worker never got the chart's Redis settings, so they always connected to the default redis-store:6379. With external Redis that host doesn't exist. Both workers use Redis for a periodic lock around their queue metrics.

This adds the same sourcegraph.redisConnection env vars and checksum/redis annotation that frontend, gitserver, searcher, and worker already use.

If you set REDIS_*_ENDPOINT in preciseCodeIntel.env or syntacticCodeIntel.env as a workaround, remove it when upgrading.

Checklist

  • Follow the manual testing process
  • Update changelog
  • Update Kubernetes update doc

Test plan

  • helm unittest: the Redis connection tests now cover both workers, including existingSecret. They fail without the template changes.
  • helm template with external Redis secrets renders both env vars and the annotation on each worker.
  • On a live instance with external Redis, the precise worker logged lookup redis-store errors. After the env vars were added by hand to the syntactic worker, traces showed it taking its Redis lock. Not deployed from this branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@marcleblanc2 @ampagent
sourcegraph: set Redis endpoints on syntactic-code-intel-worker
2d8706f
The syntactic-code-intel-worker Deployment did not set REDIS_CACHE_ENDPOINT
or REDIS_STORE_ENDPOINT, so it always fell back to its built-in default
redis-store:6379 and ignored redisCache.connection / redisStore.connection.
On instances with external Redis that host does not exist.

Use the sourcegraph.redisConnection helper and the sourcegraph.redisChecksum
pod annotation, matching frontend, gitserver, searcher, and worker.

Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2
Co-authored-by: Amp <[email protected]>
@github-actions

github-actions Bot commented Nov 11, 2026

Copy link
Copy Markdown

Open the Diff Tour for this PR in Sourcegraph

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-advanced-security[bot]
github-advanced-security Bot found potential problems Nov 11, 2026
View reviewed changes
Comment thread charts/sourcegraph/tests/redisConnection_test.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.

Comment thread charts/sourcegraph/tests/redisConnection_test.yaml Fixed

Uh oh!

There was an error while loading. Please reload this page.

marcleblanc2 and others added 2 commits November 11, 2026 03:18
@marcleblanc2 @ampagent
sourcegraph: use low-entropy secret names in redisConnection test
1bbb04e
Checkov's CKV_SECRET_6 flagged external-redis-cache / external-redis-store
as high-entropy strings.

Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2
Co-authored-by: Amp <[email protected]>
@marcleblanc2 @ampagent
sourcegraph: set Redis endpoints on precise-code-intel-worker
997bdf2
Same gap as syntactic-code-intel-worker: the Deployment set no
REDIS_*_ENDPOINT, so the worker used redis-store:6379 regardless of
redisCache.connection / redisStore.connection. Its dbworker queue metrics
reporter takes a Redis lock, which failed on instances with external Redis.

Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2
Co-authored-by: Amp <[email protected]>
@marcleblanc2 marcleblanc2 changed the title sourcegraph: set Redis endpoints on syntactic-code-intel-worker sourcegraph: set Redis endpoints on the code-intel workers Nov 11, 2026
@marcleblanc2 marcleblanc2 changed the title sourcegraph: set Redis endpoints on the code-intel workers fix/redis: set Redis endpoints on the code-intel workers Nov 11, 2026
@marcleblanc2
marcleblanc2 enabled auto-merge (squash) November 11, 2026 03:39
@marcleblanc2
marcleblanc2 requested a review from a team November 11, 2026 03:39
@marcleblanc2 marcleblanc2 mentioned this pull request Nov 11, 2026
Add external Redis example override sourcegraph/deploy-sourcegraph-docker#1482
Merged
1 task done
michaellzc
michaellzc approved these changes Nov 11, 2026
View reviewed changes

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaellzc michaellzc michaellzc approved these changes
+1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@marcleblanc2 @michaellzc @github-advanced-security
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.