GeezerVison is showing github.com — fix/redis: set Redis endpoints on the code-intel workers by marcleblanc2 · Pull Request #1004 · sourcegraph/deploy-sourcegraph-helm
Conversation
precise-code-intel-worker and syntactic-code-intel-worker never got the chart's Redis settings, so they always connected to the default redis-store:6379. With external Redis that host doesn't exist. Both workers use Redis for a periodic lock around their queue metrics.
This adds the same sourcegraph.redisConnection env vars and checksum/redis annotation that frontend, gitserver, searcher, and worker already use.
If you set REDIS_*_ENDPOINT in preciseCodeIntel.env or syntacticCodeIntel.env as a workaround, remove it when upgrading.
Checklist
Test plan
helm unittest: the Redis connection tests now cover both workers, including existingSecret. They fail without the template changes.
helm template with external Redis secrets renders both env vars and the annotation on each worker.
- On a live instance with external Redis, the precise worker logged
lookup redis-store errors. After the env vars were added by hand to the syntactic worker, traces showed it taking its Redis lock. Not deployed from this branch.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The syntactic-code-intel-worker Deployment did not set REDIS_CACHE_ENDPOINT
or REDIS_STORE_ENDPOINT, so it always fell back to its built-in default
redis-store:6379 and ignored redisCache.connection / redisStore.connection.
On instances with external Redis that host does not exist.
Use the sourcegraph.redisConnection helper and the sourcegraph.redisChecksum
pod annotation, matching frontend, gitserver, searcher, and worker.
Amp-Thread-ID: https://ampcode.com/threads/T-5e703d95-d3ee-4486-9b11-630a3ae8b3e2
Co-authored-by: Amp <[email protected]>
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
marcleblanc2
changed the title
sourcegraph: set Redis endpoints on syntactic-code-intel-worker
sourcegraph: set Redis endpoints on the code-intel workers
Nov 11, 2026
marcleblanc2
changed the title
sourcegraph: set Redis endpoints on the code-intel workers
fix/redis: set Redis endpoints on the code-intel workers
Nov 11, 2026
This branch has not been deployed
No deployments
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|