GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: still exit with non-zero when there is an unknown err by burmudar · Pull Request #1312 · sourcegraph/src-cli

Conversation

@burmudar

@burmudar burmudar commented May 5, 2026

Copy link
Copy Markdown
Contributor

If we returned an error whose type wasn't known we exited with exit code 0, instead of 1.

We now will always exit with code 1 at the very least if there is an error.

Test plan

Tested locally

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burmudar
fix: still exit with non-zero when there is an unknown err
a402555
@burmudar
burmudar requested a review from a team May 5, 2026 13:29
@burmudar burmudar self-assigned this May 5, 2026
keegancsmith
keegancsmith approved these changes May 6, 2026
View reviewed changes
@burmudar
burmudar merged commit cacf3c0 into main May 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@burmudar
burmudar deleted the wb/fix-exit-code branch May 6, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@burmudar burmudar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@burmudar @keegancsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.