GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: dedupe migrated root commands by burmudar · Pull Request #1315 · sourcegraph/src-cli

Conversation

@burmudar

@burmudar burmudar commented May 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This changes migratedRootCommand to collect commands by their canonical cli.Command.Name before sorting them for the root command. Alias dispatch entries remain supported in migratedCommands, while the generated root command only includes each command once.

Test Plan

  • go test ./cmd/src

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burmudar
dedupe migrated root commands
e4d7482
@burmudar burmudar self-assigned this May 6, 2026
@burmudar
burmudar requested a review from a team May 6, 2026 08:42
@burmudar burmudar changed the title chore/cli: dedupe migrated root commands fix: dedupe migrated root commands May 6, 2026
keegancsmith
keegancsmith approved these changes May 6, 2026
View reviewed changes
Comment thread cmd/src/run_migration_compat.go
commands = append(commands, migratedCommands[name])
uniqueCommands := make(map[string]*cli.Command, len(migratedCommands))
for _, cmd := range migratedCommands {
uniqueCommands[cmd.Name] = cmd

@keegancsmith keegancsmith May 6, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have commands with duplicated names? IE do we need to add a unique step?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@burmudar burmudar May 6, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah in the subsequent migration of codeowners and orgs we register the command twice in the set to support their current aliases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burmudar
Merge branch 'main' into wb/dedupe-migrated-commands
38029c4
@burmudar
burmudar enabled auto-merge (squash) May 6, 2026 08:57
@burmudar
Merge branch 'main' into wb/dedupe-migrated-commands
84e991d
@burmudar
burmudar merged commit 618d038 into main May 6, 2026
9 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@burmudar
burmudar deleted the wb/dedupe-migrated-commands branch May 6, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@burmudar burmudar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@burmudar @keegancsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.