GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore/cli: migrate users to urfave/cli by burmudar · Pull Request #1317 · sourcegraph/src-cli

Conversation

@burmudar

@burmudar burmudar commented May 8, 2026

Copy link
Copy Markdown
Contributor

The command migration is moving legacy commander commands onto urfave/cli so they share the same help, flag, and dispatch behavior as newly migrated commands.

Migrate src users and its list, get, create, delete, prune, and tag subcommands to cli.Command definitions. Register both users and user in the migrated command map, and remove users from the legacy docs path so generated docs come from the migrated root command.

Test Plan

  • go test ./cmd/src
  • go test ./...
  • go run ./cmd/src users -h
  • go run ./cmd/src user -h
  • go run ./cmd/src users list -h

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
keegancsmith
keegancsmith approved these changes May 8, 2026
View reviewed changes

@keegancsmith keegancsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big PR that looks super mechanical. So trusting ya tested everything still works :D

Very minor but I ran ./dev/smoke.sh and it worked which is good :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burmudar
burmudar force-pushed the wb/migrate-users branch from 1a1bb81 to 58bb98e Compare May 8, 2026 12:43
@burmudar
chore/cli: migrate users to urfave/cli
cc75989 
The command migration is moving legacy commander commands onto urfave/cli so they share the same help, flag, and dispatch behavior as newly migrated commands.

Migrate src users and its list, get, create, delete, prune, and tag subcommands to cli.Command definitions. Register both users and user in the migrated command map, and remove users from the legacy docs path so generated docs come from the migrated root command.

Test Plan:
- go test ./cmd/src
- go test ./...
- go run ./cmd/src users -h
- go run ./cmd/src user -h
- go run ./cmd/src users list -h
@burmudar
burmudar force-pushed the wb/migrate-users branch from 58bb98e to cc75989 Compare May 8, 2026 12:44
@burmudar burmudar self-assigned this May 8, 2026
@burmudar
Merge branch 'main' into wb/migrate-users
84b1e5e
@burmudar
burmudar enabled auto-merge (squash) May 8, 2026 12:52
@burmudar
Merge branch 'main' into wb/migrate-users
6e5dab8
@burmudar
burmudar merged commit 30270f5 into main May 11, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@burmudar
burmudar deleted the wb/migrate-users branch May 11, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@burmudar burmudar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@burmudar @keegancsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.