GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat/doc: do not render any progress in non-TTY environments by burmudar · Pull Request #1323 · sourcegraph/src-cli

Conversation

@burmudar

@burmudar burmudar commented May 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • We no longer use the progress bar during doc generation.
  • We only print anything if the verbose flag is given -v

Test plan

$ ./src doc -o doc-test/
$ echo $?
0

with verbose flag

go run ./cmd/src -v doc -o doc-test/
<snip>
writing: orgs/list.md...
writing: orgs/members/index.md...
writing: orgs/members/add.md...
writing: orgs/members/remove.md...
writing: users/index.md...
writing: users/create.md...
writing: users/delete.md...
vusers/get.md...
writing: users/list.md...
writing: users/prune.md...
writing: users/tag.md...
writing: version.md...
✅ 62 files rendered under doc-test/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@burmudar burmudar self-assigned this May 20, 2026
keegancsmith
keegancsmith approved these changes May 20, 2026
View reviewed changes
Comment thread lib/output/pending.go
Destroy()
}

func newPending(message FancyLine, o *Output) Pending {

@keegancsmith keegancsmith May 20, 2026

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it worth forking our behaviour from lib/output in the monorepo?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@burmudar burmudar May 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this in the latest commit where we also just remove the use of the progress bar during doc generation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@keegancsmith

keegancsmith commented May 20, 2026

Copy link
Copy Markdown
Member

I'm not exactly sure if progress is the right thing to be using here? Isn't this command super fast? IE it should have pretty much no output, unless -v is specified. WDYT?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@burmudar

burmudar commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

I'm not exactly sure if progress is the right thing to be using here? Isn't this command super fast? IE it should have pretty much no output, unless -v is specified. WDYT?

yeah I agree. I think that is the better fix here. We can then stay consistent with the monorepo too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@burmudar
remove progress bar for doc generation.
0c59802 
We only print now when the verbose flag `-v` is given. Otherwise we
print nothing and exit 0
@burmudar
burmudar force-pushed the wb/noop-pending branch from 6828f8b to 0c59802 Compare May 20, 2026 12:46
@burmudar
burmudar enabled auto-merge (squash) May 20, 2026 12:50
@burmudar
burmudar merged commit ed8850d into main May 20, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@burmudar
burmudar deleted the wb/noop-pending branch May 20, 2026 12:54
keegancsmith
keegancsmith reviewed May 20, 2026
View reviewed changes

@keegancsmith keegancsmith left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@burmudar burmudar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@burmudar @keegancsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.