GeezerVison is showing github.com — chore: update vendored Sourcegraph lib by bahrmichael · Pull Request #1328 · sourcegraph/src-cli
Conversation
bahrmichael
commented
Jun 1, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR is fully Amp-generated after I ran dev/vendor-lib.sh. See https://ampcode.com/threads/T-019e8206-7c7d-76cb-9b08-b6e0df454e15.
This updates the vendored github.com/sourcegraph/sourcegraph/lib snapshot so src-cli stays current with the shared library code it depends on.
I ran ./dev/vendor-lib.sh from this repository while ../sourcegraph was on main at bdc2f4bb8b59f78f4fa8868b2690b673b41948d4 with a clean worktree. The script refreshed the selected packages under lib/, rewrote lib/README.md with the source commit/date, and regenerated the nested lib/go.mod contents.
After vendoring, go test ./... exposed a few src-cli compatibility gaps from APIs/packages that are still used locally but no longer discovered or preserved by the raw vendoring step. I restored the still-needed validation/docgen/helper packages and kept small compatibility shims for output status bars, progress options, styles, and code-intel request logging. I also re-added the step.files target-path validation that src-cli tests still expect.
Test Plan
go test ./...
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
|
)
|
|
|
|
|
|
// See: https://github.com/ghodss/yaml/pull/65
|
|
|
replace github.com/ghodss/yaml => github.com/sourcegraph/yaml v1.0.1-0.20200714132230-56936252f152
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and regenerated the nested lib/go.mod contents
@bahrmichael Looks like you nuked it? I'll send a PR
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the result of running the vendor lib script. We may need to fix that script if this change is not intentional.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the vendor script, it looks like the go mod tidy at the end may have a silent failure.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
burmudar
burmudar approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.