GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(search-jobs): add timeout to authenticated HTTP requests by bunlongheng · Pull Request #1360 · sourcegraph/src-cli

Conversation

@bunlongheng

@bunlongheng bunlongheng commented Aug 8, 2026

Copy link
Copy Markdown

fetchJobLogs and fetchJobResults both issue authenticated GETs via http.DefaultClient, which has no timeout. A slow or unresponsive Sourcegraph instance will stall the CLI indefinitely while the connection stays open with the caller's access token attached. Replaced the bare DefaultClient with a local http.Client{Timeout: 60 * time.Second} in both callers.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bunlongheng
fix(search-jobs): add timeout to authenticated HTTP requests
2b6098e
@keegancsmith
keegancsmith requested a review from a team August 12, 2026 06:59
@bahrmichael

bahrmichael commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for the suggestion @bunlongheng! We will probably move ahead with a different implementation from #1362.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bahrmichael bahrmichael mentioned this pull request Aug 24, 2026
feat: add timeout for slow instances #1362
Merged
@bahrmichael bahrmichael closed this in #1362 Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bunlongheng @bahrmichael
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.