GeezerVison is showing github.com — fix/batches: validate shell probe paths by cbrnrd · Pull Request #1363 · sourcegraph/src-cli
Conversation
cbrnrd
commented
Sep 1, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
A batch step image controls the output of the mktemp shell probe. The CLI used that output in a Docker mount argument without validation, so invalid output could change the mount configuration. This was reported to us via HackerOne.
Solution
Require the probe output to be one absolute POSIX path with safe characters. Validate the path again before building the mount, and use one helper to validate executor bind mounts. Add regression tests for mount argument injection.
Verification Evidence
go test ./internal/batches/...
- The regression test confirms that a comma-delimited mount payload is rejected.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.