GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix/batches: validate shell probe paths by cbrnrd · Pull Request #1363 · sourcegraph/src-cli

Conversation

@cbrnrd

@cbrnrd cbrnrd commented Sep 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

A batch step image controls the output of the mktemp shell probe. The CLI used that output in a Docker mount argument without validation, so invalid output could change the mount configuration. This was reported to us via HackerOne.

Solution

Require the probe output to be one absolute POSIX path with safe characters. Validate the path again before building the mount, and use one helper to validate executor bind mounts. Add regression tests for mount argument injection.

Verification Evidence

  • go test ./internal/batches/...
  • The regression test confirms that a comma-delimited mount payload is rejected.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cbrnrd @ampagent
fix/batches: validate shell probe paths
7310cfe
Amp-Thread-ID: https://ampcode.com/threads/T-01a05d3c-cfaf-7540-9b4d-43c5e402c15b
Co-authored-by: Amp <[email protected]>
@cbrnrd
cbrnrd requested a review from a team September 1, 2026 14:04
@cbrnrd
cbrnrd marked this pull request as ready for review September 1, 2026 14:05
keegancsmith
keegancsmith approved these changes Sep 3, 2026
View reviewed changes
@cbrnrd
cbrnrd merged commit c4030b5 into main Sep 3, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@cbrnrd
cbrnrd deleted the carterbrainerd-vuln-139-i-can-escape-a-batch-step-container-through-image-controlled branch September 3, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keegancsmith keegancsmith keegancsmith approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cbrnrd @keegancsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.