GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix/serve-git: reject gitdir file repository targets by cbrnrd · Pull Request #1365 · sourcegraph/src-cli

Conversation

@cbrnrd

@cbrnrd cbrnrd commented Sep 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

This was brought to our attention via a HackerOne report.

src serve-git accepted regular files as repository targets. Git can interpret a regular file containing a gitdir: pointer and follow it outside the configured serve root, which could expose a private repository.

Solution

Require smart HTTP repository targets to be directories before invoking Git. Return a not-found response for regular files, including gitdir: pointer files.

Add a regression test that confirms Git accepts the pointer file directly but src serve-git rejects the same file over HTTP.

Verification Evidence

  • go test ./internal/servegit -count=1
  • go test ./cmd/src -run '^$'

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cbrnrd
fix/serve-git: reject gitdir file repository targets
b092b1b
@cbrnrd
cbrnrd requested a review from a team September 3, 2026 16:50
@cbrnrd
cbrnrd marked this pull request as ready for review September 3, 2026 16:51
@cbrnrd
cbrnrd enabled auto-merge (squash) September 3, 2026 16:51
DaedalusG
DaedalusG approved these changes Sep 8, 2026
View reviewed changes
@cbrnrd
Merge branch 'main' into carterbrainerd-vuln-137-a-tracked-gitdir-fil…
28dd9b5
…e-escapes-the-serve-git-root-and-exposes
@cbrnrd
cbrnrd merged commit ba67acb into main Sep 8, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@cbrnrd
cbrnrd deleted the carterbrainerd-vuln-137-a-tracked-gitdir-file-escapes-the-serve-git-root-and-exposes branch September 8, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaedalusG DaedalusG DaedalusG approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cbrnrd @DaedalusG
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.