GeezerVison is showing github.com — fix/serve-git: reject gitdir file repository targets by cbrnrd · Pull Request #1365 · sourcegraph/src-cli
Conversation
cbrnrd
commented
Sep 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
This was brought to our attention via a HackerOne report.
src serve-git accepted regular files as repository targets. Git can interpret a regular file containing a gitdir: pointer and follow it outside the configured serve root, which could expose a private repository.
Solution
Require smart HTTP repository targets to be directories before invoking Git. Return a not-found response for regular files, including gitdir: pointer files.
Add a regression test that confirms Git accepts the pointer file directly but src serve-git rejects the same file over HTTP.
Verification Evidence
go test ./internal/servegit -count=1
go test ./cmd/src -run '^$'
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…e-escapes-the-serve-git-root-and-exposes
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.