GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix/batches: reject Git metadata in repository archives by cbrnrd · Pull Request #1366 · sourcegraph/src-cli

Conversation

@cbrnrd

@cbrnrd cbrnrd commented Sep 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

This was brought to our attention via HackerOne.

A repository archive could include a .git directory. During bind workspace setup, src extracted this directory and then ran Git commands on the host. Malicious Git hooks or repository configuration could therefore run code on the host.

Solution

Reject archive entries that resolve inside the root .git directory. The check also handles normalized paths and case-insensitive filesystems.

Verification Evidence

  • go test ./internal/batches/workspace
  • go test ./internal/batches/...
  • Added tests for malicious hooks, repository configuration, normalized paths, and case variants.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cbrnrd
fix/batches: reject Git metadata in repository archives
2cadbbd
@cbrnrd
cbrnrd requested a review from a team September 3, 2026 17:09
@cbrnrd
cbrnrd marked this pull request as ready for review September 3, 2026 17:09
@cbrnrd cbrnrd mentioned this pull request Sep 3, 2026
fix/batches: prevent repository archives from enabling Git hooks #1367
Merged
BolajiOlajide
BolajiOlajide approved these changes Sep 3, 2026
View reviewed changes
@cbrnrd
cbrnrd merged commit 1bb1362 into main Sep 3, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@cbrnrd
cbrnrd deleted the carterbrainerd-vuln-142-a-repository-archive-containing-githookspre-commit-achieves branch September 3, 2026 17:55
@cbrnrd cbrnrd mentioned this pull request Sep 4, 2026
fix/batches: discard extracted Git metadata before Git initialization #1370
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BolajiOlajide BolajiOlajide BolajiOlajide approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cbrnrd @BolajiOlajide
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.