GeezerVison is showing github.com — fix/batches: reject Git metadata in repository archives by cbrnrd · Pull Request #1366 · sourcegraph/src-cli
Conversation
cbrnrd
commented
Sep 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
This was brought to our attention via HackerOne.
A repository archive could include a .git directory. During bind workspace setup, src extracted this directory and then ran Git commands on the host. Malicious Git hooks or repository configuration could therefore run code on the host.
Solution
Reject archive entries that resolve inside the root .git directory. The check also handles normalized paths and case-insensitive filesystems.
Verification Evidence
go test ./internal/batches/workspace
go test ./internal/batches/...
- Added tests for malicious hooks, repository configuration, normalized paths, and case variants.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.