GeezerVison is showing github.com — fix/batches: prevent command injection from repository paths by cbrnrd · Pull Request #1373 · sourcegraph/src-cli
Conversation
cbrnrd
commented
Sep 8, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
When a volume workspace copied extra repository files, it added repository-controlled paths directly to Docker mount arguments and a shell command. A crafted directory name could change the mount configuration and run commands inside the trusted workspace helper. Those commands could read files from the machine running src.
This fixes VULN-140.
Solution
Package the extra files in a temporary tar archive. Validate that every archive path is relative and clean, mount the archive at a fixed location, and extract it with fixed tar arguments. Repository paths are now treated only as data and are not interpreted by Docker or a shell.
Verification Evidence
go test ./internal/batches/...
- Added a regression test with a repository path containing shell and Docker mount syntax.
- Ran the volume workspace helper in Docker and confirmed that it extracted the crafted path as a normal file without running it as a command.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.