GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix/batches: prevent executor environment leakage to steps by cbrnrd · Pull Request #1374 · sourcegraph/src-cli

Conversation

@cbrnrd

@cbrnrd cbrnrd commented Sep 8, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

Batch steps can request environment variables by name. The executor passed its full process environment into this resolver, so a step could request reserved SRC_EXECUTOR_* values. These values include executor control credentials that must not be available inside an ordinary batch step.

This fixes VULN-141.

Solution

Filter the reserved SRC_EXECUTOR_* namespace from the outer environment before resolving step variables. The filter is applied at the step execution boundary, so it covers every caller and also protects future variables in the reserved namespace. Normal environment variables and explicit step values continue to work.

Verification Evidence

  • Added a regression test showing that normal outer variables still resolve.
  • Added coverage showing that current and future SRC_EXECUTOR_* outer variables resolve to empty values.
  • go test ./internal/batches/...
  • go test ./cmd/src

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cbrnrd
cbrnrd marked this pull request as ready for review September 8, 2026 15:47
@cbrnrd
cbrnrd requested a review from a team September 8, 2026 15:47
DaedalusG
DaedalusG approved these changes Sep 8, 2026
View reviewed changes
@cbrnrd Graphite App

cbrnrd commented Sep 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Sep 9, 1:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Sep 9, 1:28 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 9, 1:35 PM UTC: Graphite rebased this pull request as part of a merge.
  • Sep 9, 1:42 PM UTC: @cbrnrd merged this pull request with Graphite.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@cbrnrd
cbrnrd force-pushed the carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch branch from 657dd83 to f9d1767 Compare September 9, 2026 13:27
@cbrnrd
fix/batches: prevent executor environment leakage to steps
ef9c84a
@cbrnrd
cbrnrd force-pushed the carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch branch from f9d1767 to ef9c84a Compare September 9, 2026 13:34
@cbrnrd
cbrnrd merged commit ed0828d into main Sep 9, 2026
8 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@cbrnrd
cbrnrd deleted the carterbrainerd-vuln-141-i-can-use-a-reserved-executor-bearer-from-a-normal-v2-batch branch September 9, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaedalusG DaedalusG DaedalusG approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cbrnrd @DaedalusG
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.