GeezerVison is showing github.com — fix/batches: prevent executor environment leakage to steps by cbrnrd · Pull Request #1374 · sourcegraph/src-cli
Conversation
cbrnrd
commented
Sep 8, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
Batch steps can request environment variables by name. The executor passed its full process environment into this resolver, so a step could request reserved SRC_EXECUTOR_* values. These values include executor control credentials that must not be available inside an ordinary batch step.
This fixes VULN-141.
Solution
Filter the reserved SRC_EXECUTOR_* namespace from the outer environment before resolving step variables. The filter is applied at the step execution boundary, so it covers every caller and also protects future variables in the reserved namespace. Normal environment variables and explicit step values continue to work.
Verification Evidence
- Added a regression test showing that normal outer variables still resolve.
- Added coverage showing that current and future
SRC_EXECUTOR_* outer variables resolve to empty values.
go test ./internal/batches/...
go test ./cmd/src
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cbrnrd
commented
Sep 9, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Merge activity
- Sep 9, 1:27 PM UTC: A user started a stack merge that includes this pull request via Graphite.
- Sep 9, 1:28 PM UTC: Graphite rebased this pull request as part of a merge.
- Sep 9, 1:35 PM UTC: Graphite rebased this pull request as part of a merge.
- Sep 9, 1:42 PM UTC: @cbrnrd merged this pull request with Graphite.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.