GeezerVison is showing github.com — npm: drop unused dependencies by marcleblanc2 · Pull Request #1397 · sourcegraph/src-cli
Conversation
marcleblanc2
commented
Nov 3, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Problem
-
npm-distribution/package.json includes old unneeded, and should be tidied
-
Renovate also opens unnecessary PRs to update them
Solution
-
Remove the overrides block
-
Remove @types/tar
npm-distribution/ has no TypeScript (three .js files), and tar 7 ships its own types
-
Regenerated package-lock.json via npm install --package-lock-only
-
Once merged, Renovate should close the five PRs above on its own since the packages are no longer declared
Test plan
- Verified locally:
npm ci from the new lockfile, npm audit reports 0 vulnerabilities, require("tar") loads
Amp thread
https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
marcleblanc2
changed the title
npm: drop stale overrides and the unused @types/tar devDependency
npm: drop unused dependencies
Nov 3, 2026
The overrides block was added in #1218 and #1219 to force patched
versions of cross-spawn, glob, and brace-expansion, which tar 7.1
pulled in through rimraf. tar 7.5 (#1319, #1357) dropped rimraf, so
none of those packages are in the dependency tree anymore and the
overrides have no effect. Renovate still reads them as declared
dependencies and keeps opening PRs to bump them (#1389, #1390, #1392,
#1393).
@types/tar is unused: npm-distribution has no TypeScript, and tar 7
ships its own types (#1391 would have replaced it with a deprecated
stub).
Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|