GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — npm: drop unused dependencies by marcleblanc2 · Pull Request #1397 · sourcegraph/src-cli

Conversation

@marcleblanc2

@marcleblanc2 marcleblanc2 commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Problem

  • npm-distribution/package.json includes old unneeded, and should be tidied

  • Renovate also opens unnecessary PRs to update them

    • Update dependency cross-spawn to ^7.0.6 #1389
    • Update dependency brace-expansion to ^2.1.7 #1390
    • Update dependency @types/tar to v7 #1391
    • Update dependency brace-expansion to v5 #1392
    • Update dependency glob to v14 #1393

Solution

  • Remove the overrides block

    • It was added in fix: upgrade glob to 10.5.0 (CVE-2025-64756) #1218 and fix: upgrade cross-spawn to 7.0.6 (CVE-2024-21538) #1219 to force patching cross-spawn, glob, and brace-expansion, which tar 7.1 pulled in through rimraf
    • tar 7.5 (chore/security: update deps for CVEs reported by trivy #1319, chore/deps: bump vulnerable dependencies ahead of 7.6.0 release #1357) dropped rimraf, so none of those packages are in the lockfile anymore and the overrides are no longer effective
  • Remove @types/tar

    • npm-distribution/ has no TypeScript (three .js files), and tar 7 ships its own types
  • Regenerated package-lock.json via npm install --package-lock-only

  • Once merged, Renovate should close the five PRs above on its own since the packages are no longer declared

Test plan

  • Verified locally: npm ci from the new lockfile, npm audit reports 0 vulnerabilities, require("tar") loads

Amp thread

https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@github-actions

github-actions Bot commented Nov 3, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open the Diff Tour for this PR in Sourcegraph

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@marcleblanc2 marcleblanc2 changed the title npm: drop stale overrides and the unused @types/tar devDependency npm: drop unused dependencies Nov 3, 2026
@marcleblanc2
marcleblanc2 requested a review from DaedalusG November 3, 2026 23:29
@marcleblanc2
marcleblanc2 force-pushed the marc/npm-drop-stale-overrides branch from 2c695b2 to 94f09e2 Compare November 4, 2026 00:30
@marcleblanc2
marcleblanc2 changed the base branch from main to marc/ci-release-artifact-checks November 4, 2026 00:30
@marcleblanc2
marcleblanc2 added this pull request to stack #1399 November 4, 2026 00:30
@marcleblanc2
marcleblanc2 requested a review from a team November 9, 2026 22:51
@michaellzc
michaellzc requested review from a team and removed request for a team and DaedalusG November 9, 2026 23:02
BolajiOlajide
BolajiOlajide approved these changes Nov 10, 2026
View reviewed changes
Base automatically changed from marc/ci-release-artifact-checks to main November 10, 2026 17:40
@marcleblanc2 @ampagent
npm: drop stale overrides and the unused @types/tar devDependency
92846e0
The overrides block was added in #1218 and #1219 to force patched
versions of cross-spawn, glob, and brace-expansion, which tar 7.1
pulled in through rimraf. tar 7.5 (#1319, #1357) dropped rimraf, so
none of those packages are in the dependency tree anymore and the
overrides have no effect. Renovate still reads them as declared
dependencies and keeps opening PRs to bump them (#1389, #1390, #1392,
#1393).

@types/tar is unused: npm-distribution has no TypeScript, and tar 7
ships its own types (#1391 would have replaced it with a deprecated
stub).

Co-authored-by: Amp <[email protected]>
Amp-Thread-ID: https://ampcode.com/threads/T-01a1a37e-8603-775d-bc85-c5677817f7a8
@marcleblanc2
marcleblanc2 force-pushed the marc/npm-drop-stale-overrides branch from 94f09e2 to 92846e0 Compare November 10, 2026 17:41
@marcleblanc2
marcleblanc2 merged commit 9b493d6 into main Nov 10, 2026
12 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@marcleblanc2
marcleblanc2 deleted the marc/npm-drop-stale-overrides branch November 10, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BolajiOlajide BolajiOlajide BolajiOlajide approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@marcleblanc2 @BolajiOlajide
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.