GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(cli): take --ca-bundle on build and up only by aledbf · Pull Request #58 · spin-stack/devcontainer-cli

Conversation

@aledbf

@aledbf aledbf commented Nov 12, 2026

Copy link
Copy Markdown
Member

Follow-up to #57.

run-user-commands --ca-bundle took a bundle path, checked that it held PEM, and then used it only as a switch: the variables it set point at the copy up bound into the container, never at the file passed. up --ca-bundle already puts those variables in the container's environment, and the lifecycle commands inherit them through the user-env probe, so the flag added nothing.

  • run-user-commands no longer takes --ca-bundle (it is now an unknown flag); caBundleRemoteEnv and containerHasCABundle are gone with it.
  • docs/go-only-features.md, docs/DIVERGENCES.md and docs/parity/cli-flags-inventory.yaml list the flag on build and up only.

Compatibility: the flag arrived in #57 and no release contains it (latest is v20260921.02), so no user depends on it.

Tests

  • TestRunUserCommandsTakesNoCABundle: fails on main (the flag is accepted), passes here.
  • TestE2E_CABundle: after up --ca-bundle, run-user-commands with no flag reruns a postAttachCommand that reaches the TLS server signed by the test CA.

Validation (local)

  • go tool task lint: pass.
  • go test ./internal/cli/ -run 'CABundle|RunUserCommands|Inventory' (e2e included, with Docker): pass.
  • go tool task test:race and go tool task parity:contract: the only failures are the TestOpen* tests, TestComputeWorkspaceConfigOutsideARepository and two read-configuration parity cases. The first two groups fail identically on main; all trace back to a /tmp/.git on the dev machine. CI is the check for those.

🤖 Generated with Claude Code

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aledbf @claude
refactor(cli): take --ca-bundle on build and up only
66ea1fe
run-user-commands took a bundle path, checked it held PEM, and then
used it only as a switch: the variables it set point at the copy up
bound into the container, never at the file given. up --ca-bundle
already puts those variables in the container's environment, which the
lifecycle commands inherit through the user-env probe, so the flag
added nothing. The flag has not been released, so nothing depends on it.

run-user-commands now rejects --ca-bundle as an unknown flag, and the
e2e test checks that its postAttachCommand trusts the proxy's CA with
no flag at all.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@aledbf
aledbf merged commit 5aa1dc3 into main Nov 12, 2026
13 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@aledbf
aledbf deleted the ca-bundle-build-up-only branch November 12, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@aledbf
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.