GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor(models)!: remove the deprecated JsonUtil classes by dargmuesli · Pull Request #493 · spotify-web-api-java/spotify-web-api-java

Conversation

@dargmuesli

@dargmuesli dargmuesli commented Nov 5, 2026

Copy link
Copy Markdown
Member

Stacked on #492, which sits on #487. Removes the deprecated JsonUtil API: every model's nested JsonUtil class, their base class AbstractModelObject.JsonUtil and the interface IModelObject.IJsonUtil. All of it was deprecated in 10.x in favour of ModelObjects, and the library itself no longer calls any of it.

PlaylistItemFactory goes with them: its only method took a Gson JsonObject, and that reader now lives in the internal ModelObjectGson, so the model_objects.utils package is no longer exported from the module. MIGRATION.md maps each removed call to its ModelObjects replacement. The JsonObject and JsonArray overloads, and the variants that read a named member of the JSON, have no replacement, because ModelObjects takes the JSON as a String.

This is a breaking change, so the commit carries the ! and the removals are recorded in MIGRATION.md under 10.0.0 to 11.0.0. Verified locally: 426 tests pass, codegen/generate.py --check reports no drift, ci/check-docs.py checks all 115 examples, Javadoc passes doclint, and the examples module compiles.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dargmuesli
dargmuesli force-pushed the refactor/build/generated-source-root branch from 8df3f20 to 21f14fd Compare November 5, 2026 12:36
@dargmuesli
refactor(models)!: remove the deprecated JsonUtil classes
6c5a6f4 
Every model's nested JsonUtil, AbstractModelObject.JsonUtil and
IModelObject.IJsonUtil were deprecated in 10.x in favour of ModelObjects and
no longer used by the library. PlaylistItemFactory goes with them: its only
method took a Gson JsonObject, and the reader now lives in the internal
ModelObjectGson, so the model_objects.utils package is no longer exported.

MIGRATION.md maps each removed call to its ModelObjects replacement.

Refs #461
@dargmuesli
dargmuesli force-pushed the refactor/models/remove-json-util branch from acbdd85 to 6c5a6f4 Compare November 5, 2026 12:36
@codecov

codecov Bot commented Nov 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.10%. Comparing base (21f14fd) to head (6c5a6f4).

Files with missing lines Patch % Lines
...ichaelthelin/spotify/internal/ModelObjectGson.java 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@                            Coverage Diff                             @@
##             refactor/build/generated-source-root     #493      +/-   ##
==========================================================================
+ Coverage                                   35.82%   37.10%   +1.27%     
  Complexity                                    509      509              
==========================================================================
  Files                                         107      106       -1     
  Lines                                        4446     4282     -164     
  Branches                                      205      196       -9     
==========================================================================
- Hits                                         1593     1589       -4     
+ Misses                                       2763     2603     -160     
  Partials                                       90       90

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Base automatically changed from refactor/build/generated-source-root to beta November 5, 2026 12:38
@dargmuesli
dargmuesli merged commit ee9c365 into beta Nov 5, 2026
6 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@dargmuesli
dargmuesli deleted the refactor/models/remove-json-util branch November 5, 2026 12:41
This was referenced Nov 5, 2026
refactor: reduce boilerplate code #461
Closed
refactor(module)!: require Gson without re-exporting it #494
Merged
ci(release): v11 #484
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@dargmuesli
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.