GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [RFC] support build with custom (non-standard) functions by brody2consult · Pull Request #320 · sql-js/sql.js

Conversation

@brody2consult

@brody2consult brody2consult commented Jan 9, 2020

Copy link
Copy Markdown

This is just an idea of how it may be possible to support developers who need to build with non-standard functions. Here is an example where I support UPPER and LOWER functions that can handle many EU characters properly: https://github.com/brodybits/sql.js/tree/custom-eu-string-functions

This idea includes some comments that I think should be considered in src/api.coffee that can help make it easier for people like myself to add custom functions in the future.

I suspect there should be a much smarter way to do this, by using an array of FuncDef structures like they do in extension-functions.c for example.

I will very likely continue with the kind of solution proposed here to support the needs of my customer, with hope for a more standardized solution (someday).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@brody2consult
brody2consult force-pushed the custom-functions branch from 86865e6 to e316007 Compare January 9, 2020 17:56
Christopher J. Brody
add custom_extensions function in a new module
6a20a45
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript
@brody2consult
brody2consult force-pushed the custom-functions branch from 06f6789 to 6a20a45 Compare January 12, 2020 19:54
brody2consult referenced this pull request in brody2consult/sql.js Jan 13, 2020
Christopher J. Brody
add custom_extensions function in a new module
a486b93
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brody2consult referenced this pull request in brody2consult/sql.js Jan 13, 2020
Christopher J. Brody
add custom_extensions function in a new module
1b62e3d
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
brody2consult referenced this pull request in brody2consult/sql.js Jan 13, 2020
Christopher J. Brody
add custom_extensions function in a new module
162b786
for custom (non-standard) SQLite3 extension functions that may be
added in the future

with some additional explanatory comments added to the CoffeeScript

as proposed in: https://github.com/kripken/sql.js/pull/320
This was referenced Feb 18, 2020
Not able to use exported c function as custom function in query #310
Open
load extension #342
Closed
@lovasoa
lovasoa force-pushed the master branch from b3211a6 to e902ec2 Compare February 29, 2020 11:04
@brody2consult brody2consult mentioned this pull request Apr 2, 2020
JSON1? #259
Closed
@lovasoa
lovasoa force-pushed the master branch from 351ffdd to 6e7ec33 Compare October 11, 2020 20:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@brody2consult
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.