GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Query Plan Guidance Framework by bajinsheng · Pull Request #661 · sqlancer/sqlancer

Conversation

@bajinsheng

@bajinsheng bajinsheng commented Dec 18, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator
  • Add the framework of Query Plan Guidance (QPG).
  • Add the QPG implementation of SQLite CockroachDB and TiDB.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hawkingrei and mrigger reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@bajinsheng
bajinsheng requested a review from mrigger December 18, 2022 12:42
@bajinsheng bajinsheng mentioned this pull request Dec 18, 2022
Support QPG #641
Closed
mrigger
mrigger reviewed Dec 18, 2022
View reviewed changes
Comment thread src/sqlancer/MainOptions.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/sqlancer/sqlite3/SQLite3Provider.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/sqlancer/DatabaseProvider.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
mrigger
mrigger reviewed Dec 18, 2022
View reviewed changes
Comment thread src/sqlancer/sqlite3/SQLite3Provider.java Resolved

Uh oh!

There was an error while loading. Please reload this page.
bajinsheng added 4 commits December 19, 2022 10:19
bajinsheng
QPG framework
0854862
bajinsheng
QPG for SQLite
9be29ef
bajinsheng
QPG for CockroachDB
2f40941
bajinsheng
QPG for TiDB
ddff945
@bajinsheng
bajinsheng requested a review from mrigger December 19, 2022 02:25
mrigger
mrigger reviewed Dec 19, 2022
View reviewed changes
Comment thread src/sqlancer/cockroachdb/CockroachDBProvider.java
}

@Override
public String getQueryPlan(String selectStr, CockroachDBGlobalState globalState) throws Exception {

@mrigger mrigger Dec 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to add a couple of test cases (perhaps in a future PR) for parsing the query plans to ensure that everything still works after updating the database systems.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mrigger
mrigger approved these changes Dec 19, 2022
View reviewed changes

@mrigger mrigger left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bajinsheng
bajinsheng merged commit 38bf640 into sqlancer:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrigger mrigger mrigger approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bajinsheng @mrigger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.