GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — fix: escape enum values as Go string literals in generated code (#4448) by ArdyJunata · Pull Request #4481 · sqlc-dev/sqlc ConversationSummaryFixes #4448 ProblemEnum values were interpolated raw into the Go code generation template: This causes silent data corruption for any PostgreSQL enum value containing special characters:
FixReplace Go's Before: UserRoleUsernadmin UserRole = "user\nadmin" // \n = newline! (10 bytes) After: UserRoleUsernadmin UserRole = "user\\nadmin" // correct (11 bytes, matches DB) TestingRegression tests added in
All 13 new sub-tests pass.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsFixes sqlc-dev#4448 Enum values containing backslashes, double quotes, or other special characters were interpolated raw into the Go template: {{.Name}} {{.Type}} = "{{.Value}}" This caused silent data corruption: a PostgreSQL enum value like 'user\nadmin' (literal backslash + n, 11 bytes) became the Go constant "user\nadmin" (newline character, 10 bytes). Comparisons against the database value silently fail at runtime. Values containing double quotes broke go/format.Source() entirely. Values like 'injected" + "code" + "' generated valid-but-wrong Go string concatenation expressions. Fix: replace "{{.Value}}" with {{printf "%q" .Value}}. Go's %q verb produces a properly double-quoted, fully-escaped string literal — backslashes are doubled, double quotes are escaped, control characters use named sequences. The outer quotes are included by %q, so no surrounding quotes are needed in the template. Before: UserRoleUsernadmin UserRole = "user\nadmin" // newline! After: UserRoleUsernadmin UserRole = "user\\nadmin" // correct Regression tests added in internal/codegen/golang/enum_test.go covering: - plain values (unchanged) - literal backslash sequences (\n, \t, \\) - embedded control characters - double quotes in values - string concatenation injection pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Silent Data Corruption via Unescaped Enum Values in Generated Go CodeUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |