GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — fix(mysql): encode copyfrom enum values as strings by fzlzjerry · Pull Request #4613 · sqlc-dev/sqlc ConversationFixes #4324. Generated non-null enums are defined string types. Passing them to Recognize the generated Go enum names, including the qualifier used for split models, and emit The production change is 11 added lines. The remaining files are CLI inputs and generated goldens for default arguments, parameter-struct pointers and split models. They cover multi-column and scalar enums, nullable values, an overridden enum, ordinary strings and INSERT/REPLACE conversion. Existing goldens, models, dependencies and public APIs are unchanged. Validation:
REPLACE duplicate-key behavior stays with #4559. The runtime REPLACE cases use fresh keys to isolate the enum encoding problem; this PR does not claim to fix that separate semantic issue.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Generated non-null enums are named string types, which mysqltsv does not accept through AppendValue. Recognize generated enum names, including external model qualification, and emit AppendString with an explicit string conversion. Keep nullable driver.Valuer wrappers, overrides and ordinary types on their existing paths. Add CLI golden cases for scalar arguments, parameter-struct pointers and split models, with nullable, overridden and text controls. Verified the tagged CI suite with all required process plugins, six CGO-free build targets, and live MySQL round trips. REPLACE duplicate-key semantics remain separate from this encoding fix. Fixes sqlc-dev#4324 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Copilot code review
Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. MySQL copyfrom throws "can't encode type models.ExperienceLocationsType to TSV" if models.ExperienceLocationsType is a string enumUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |