GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — golang: emit one argument for a named parameter used more than once by tlq5l · Pull Request #4651 · sqlc-dev/sqlc

Conversation

@tlq5l

@tlq5l tlq5l commented Oct 21, 2026

Copy link
Copy Markdown

Fixes #4191

With query_parameter_limit above the number of parameters, the Go codegen lists each parameter as a method argument. A named parameter used twice (sqlc.narg(name) in name = ? OR ? IS NULL) is two parameters on MySQL, so it produced ListUsers(ctx, name sql.NullString, name sql.NullString) and the package did not compile.

The struct form already treats such parameters as one field (columnsToStruct gives them the same name and UniqueFields declares it once). QueryValue.Pairs built the inline argument list from all fields instead. It now uses UniqueFields, so the argument is declared once and still bound to both placeholders.

Added an end-to-end case, query_parameter_limit_repeated_narg, that repeats sqlc.narg(name) alongside another parameter.

Ran live: sqlc generate && go vet ./db on the issue's schema and query with query_parameter_limit: 5 -> before: name redeclared in this block; after: generates ListUsers(ctx, name sql.NullString, minAge int32) calling QueryContext(..., name, name, minAge) and vet passes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tlq5l
golang: emit one argument for a named parameter used more than once
2c47512
Agent: claude
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optional WHERE parameters via $1 IS NULL OR - redeclared in this block - query_parameter_limit

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@tlq5l
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.