GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix(core): resolve a struct field through its column by xen0l · Pull Request #4661 · sqlc-dev/sqlc ConversationFixes #4655 Problem
Change
TestsNew end-to-end case:
I also ran the generated Go on DuckDB v1.5.6 ( Not run: the Not changed
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionstypeColumnRef read only the first two parts of a column reference. For i.info.label it resolved the column info and dropped label, so the result had the type of the whole struct. For info.label it looked for a relation named info and reported an unknown column. Resolve the first part as a column when it is not a relation, then walk the remaining parts as fields of the column's struct type. A field is nullable and has no source column. An unknown field is an error. Adds the duckdb_struct_field end-to-end case.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. duckdb:col.field of a STRUCT column does not resolve, and alias.col.field is typed as the whole struct
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |