GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix(duckdb): rewrite sqlc.arg and @name to native placeholders by xen0l · Pull Request #4664 · sqlc-dev/sqlc ConversationFixes #4658 ProblemThe preprocess dialect table ( Change
Why TestsNew end-to-end cases:
I ran the generated Go of the first case on DuckDB v1.5.6 ( Not run: the Notes
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsThe preprocess dialect table had no entry for DuckDB, and an engine with no entry gets its source back unchanged. sqlc.arg(), sqlc.narg() and @name then reached the analyzer as function calls and column names. Add a DuckDB entry that uses $1 placeholders. Reject sqlc.slice for this dialect. With $1 placeholders the generated Go still calls strings.Replace on a "?" marker that the SQL does not contain, so it binds only the first element of the list and returns wrong rows without an error. A list parameter (list_contains or ANY) is the DuckDB way to do this. Adds the duckdb_named_params and analyze_slice_rejected cases.
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. duckdb:sqlc.arg(), sqlc.narg() and @name are not rewritten
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |