GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(sqlite): honor aliases in RETURNING when naming result columns by kevin9327 · Pull Request #4681 · sqlc-dev/sqlc ConversationSummarySQLite Aliases (with or without Fixes #4680 Test planAdded AI assistanceThis change was prepared with assistance from Grok Bot. I reviewed the SQLite converter against the SELECT path, generated the goldens before and after the fix, and ran the returning end-to-end tests locally.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsconvertReturning copied each RETURNING expression into a ResTarget but never set ResTarget.Name from the column alias, so field names came from the underlying column or ColumnN. SELECT already passed the alias through convertResultColumns. Fixes sqlc-dev#4680 Signed-off-by: kevin9327 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. sqlite: aliases in RETURNING are ignored when naming result columnsUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |