GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(postgres): include column comments in schema context by gezerui888 · Pull Request #193 · sqlchat/sqlchat

Conversation

@gezerui888

@gezerui888 gezerui888 commented Oct 24, 2026

Copy link
Copy Markdown

PostgreSQL schema context omitted column comments. I now include them as COMMENT ON COLUMN statements, with identifiers and comment text escaped by PostgreSQL. Comments stay with the correct schema and column, including after a column is dropped.

I added a PostgreSQL integration test and connected it to PR CI. This covers the PostgreSQL part of #155.

Tests: PostgreSQL 16 integration test (fails on the original connector, passes with the change), npm run lint, and npm run build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gezerui888
feat(postgres): include column comments in schema context
cb14249
@gezerui888
gezerui888 requested review from boojack and tianzhou as code owners October 24, 2026 19:17
@gezerui888
ci: pin pnpm to the tested version
669c12c
@gezerui888

gezerui888 commented Oct 25, 2026

Copy link
Copy Markdown
Author

I pinned CI to pnpm 10.34.8 after the unpinned version failed during dependency installation. Frozen-lockfile installation, lint, the PostgreSQL 16 integration test, and the production build pass with this version.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gezerui888

gezerui888 commented Oct 26, 2026

Copy link
Copy Markdown
Author

Hi @tianzhou, could you review my PostgreSQL column comments change when you have time? Thanks for your help.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gezerui888

gezerui888 commented Oct 29, 2026

Copy link
Copy Markdown
Author

Hi @tianzhou, I would appreciate a review when you have time.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianzhou tianzhou Awaiting requested review from tianzhou tianzhou is a code owner
@boojack boojack Awaiting requested review from boojack boojack is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@gezerui888
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.