GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — RFC: NDK r25 LTS updates by brody2consult · Pull Request #610 · sqlcipher/android-database-sqlcipher

Conversation

@brody2consult

@brody2consult brody2consult commented Jan 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
  • drop Jelly Bean support - update minimum API to 19 (KitKat), as needed by NDK beyond outdated r23 ref:
    • https://github.com/android/ndk/wiki/Changelog-r24
  • update recommended NDK to r25b ref:
    • https://developer.android.com/ndk/downloads
    • https://github.com/android/ndk/wiki/Changelog-r25

rationale:

  • It looks like NDK pre-r25 is no longer supported
  • Jelly Bean is now super-old, no longer supported beyond NDK r23, does not look worth supporting too much longer

supersedes other proposals:

  • docs: only specify minimum Android version [Jelly Bean] #609 - now included in this PR
  • DRAFT RFC docs: update recommended NDK -> r23c #608

✅ tested updated build together with androidx.sqlite/sqlite 2.1.0 (PR #501) in sqlcipher/sqlcipher-android-tests#44 ... looks like several tests need some more compiler flags

I need to build an updated version with some customizations for an organization and may even drop KitKat in my own fork, hoping to keep divergence to a minimum. Happy new year and thanks in advance for your consideration!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christopher J. Brody added 2 commits January 10, 2023 14:23
Christopher J. Brody
refactor(build)!: drop Jelly Bean support
a64ba19 
as needed by NDK beyond outdated r23 ref:

- https://github.com/android/ndk/wiki/Changelog-r24
Christopher J. Brody
docs: update recommended NDK -> r25b (LTS)
a0d8b3a 
ref:

- https://developer.android.com/ndk/downloads
- https://github.com/android/ndk/wiki/Changelog-r25
@brody2consult
brody2consult marked this pull request as draft January 10, 2023 19:32
@brody2consult
brody2consult force-pushed the ndk-r25-lts-updates branch from 546479a to a0d8b3a Compare January 10, 2023 19:33
@brody2consult
brody2consult marked this pull request as ready for review January 10, 2023 20:35
@sjlombardo sjlombardo closed this Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brody2consult @sjlombardo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.