Description

horst-p-w-neubauer

opened on Apr 22, 2020

Issue body actions

Details for the issue

when you change style and EditDialog Value is null it doesn’t change

when EditDialog Value isn’t null, it works fine

after swapping to table (filled) and back to empty SQL-Tab everthing is fine)

works both ways the same: dark to light and light to dark

Useful extra information

The info below often helps, please fill it out if you're able to. :)

What operating system are you using?

• [x ] Windows: ( _version:_7 ___ )

What is your DB4S version?

• [ x] 3.12.0-(alpha or betas)

Did you also

• Try out the latest nightly version: https://github.com/sqlitebrowser/sqlitebrowser#nightly-builds
• [x ] Search for an existing similar issue: https://github.com/sqlitebrowser/sqlitebrowser/issues?utf8=%E2%9C%93&q=is%3Aissue%20

Activity

1. horst-p-w-neubauer commented on May 6, 2020

   

   horst-p-w-neubauer

   on May 6, 2020

   MemberAuthor

   More actions

   Same if you browse a table, click into a cell - EditDock shows cell-data, change main tab to pragmas and change to/from dark style - EditDock is not gonna be refreshed immediately.
2. mgrojo

   added

   bugConfirmed bugs or reports that are very likely to be bugs.Confirmed bugs or reports that are very likely to be bugs.

   gui

   on May 6, 2020
3. mgrojo commented on May 6, 2020

   

   mgrojo

   on May 6, 2020

   Member

   More actions

   I had a lot of problems reapplying settings to the QScintilla widget. Either it is broken or I don't understand the logic.
4. horst-p-w-neubauer commented on May 7, 2020

   

   horst-p-w-neubauer

   on May 7, 2020

   MemberAuthor

   More actions

   @mgrojo , I think there are different minor refresh issues related to the EditDock and, sorry, I don't realy think its the widget itself.
   If I add
   editDock->setCurrentIndex(QModelIndex());
   after
   editDock->reloadSettings();
   in void MainWindow::reloadSettings()
   it works - but thats probably only an workarround - not a solution.

   What I don't understand: When I select a cell in the Data Browser - than switch to Strucutre Tab - the EditDialog is allready showing the last selected value - switching back to the Data Browser it changes to a value, that is not realy inside the selected table.
5. MKleusberg

   added a commit that references this issue on Jun 3, 2020

   Remove "NULL" in margin of editor in Edit dialog for empty cells

   f81da0d
6. MKleusberg commented on Jun 3, 2020

   

   MKleusberg

   on Jun 3, 2020

   Member

   More actions

   I'm not 100% sure I can follow you because on your screenshots you don't show the cells you click. But here's what I think I understood:

   • Click any cell with NULL value -> the Edit dialog shows "NULL" in the line number area of the text editor
   • Click a cell with an empty string value -> the Edit dialog still shows "NULL" in the line number area

   This issue should be solved with the latest commit. Can you double check it's working and confirm that's the issue you meant 😄 Do you know if this issue already existed in version 3.11.2?
7. mgrojo

   added a commit that references this issue on Aug 22, 2020

   Remove "NULL" in margin of editor in Edit dialog for empty cells

   441a68a

Issue actions