GeezerVison is showing github.com — Chinese and Japanese comment text affects the execution of SQL statements · Issue #3731 · sqlitebrowser/sqlitebrowser
Chinese and Japanese comment text affects the execution of SQL statements #3731DescriptionWhat did you do?
i created a sample SQL statement, and add some comment:
CREATE TABLE "FileDetails" (
"id" INTEGER UNIQUE,
"Field1" TEXT,
"Field3" TEXT,
PRIMARY KEY("id" AUTOINCREMENT)
)
--Test SQL: 有列FileName, Field1, Field2. 冩一條sql語句根據FileName 模糊查詢: 首先根據 Fields1, 然後根據每個分組的Fields2值倒序, 然後合並所有
select * from FileDetails
What did you expect to see?
Get the results
What did you see instead?
Video_2024-09-12_175401.mp4
DB4S Version
3.13.0
What OS are you seeing the problem on?
Windows
OS version
Windows10
Relevant log output
No response
Prevention against duplicate issues
- I have searched for similar issues
Activityjustinclift commented on Sep 13, 2024 Uh oh, that looks like our parsing of lines in the Execute SQL tab still needs some work. 😦
I wonder if the non-latin unicode characters is what's causing the problem.
As a diagnostic step, what happens if you replace the asian language characters with some kind of ascii placeholder (ie a)? If things suddenly start working properly, then it's pretty likely some kind of problem in our unicode handling. os9sur commented on Sep 13, 2024
Uh oh, that looks like our parsing of lines in the Execute SQL tab still needs some work. 😦哦哦，看起来我们在执行 SQL 选项卡中的行解析仍然需要一些工作。 😦
I wonder if the non-latin unicode characters is what's causing the problem.我想知道非拉丁 unicode 字符是否是导致问题的原因。
As a diagnostic step, what happens if you replace the asian language characters with some kind of ascii placeholder (ie a)? If things suddenly start working properly, then it's pretty likely some kind of problem in our unicode handling.作为诊断步骤，如果用某种 ASCII 占位符（即 a）替换亚洲语言字符，会发生什么？ 如果事情突然开始正常工作，那么很可能是我们的 unicode 处理中出现了某种问题。
Yeah, If I replace it with English, then it works fine!
Currently, I have tested Chinese(Simplified) and Chinese(Traditional) and Japanese, they are all such issue.🧐 justinclift commented on Sep 13, 2024 Thanks. Yeah that sounds like a bug we'll need to look into.
@lucydodo This might be something to look at for 3.13.1, though I suspect it could turn out to be tricky. The parsing aspect of Execute SQL text has (from rough memory) been a pain before.
Oh, I think @mgrojo might be into this stuff? changed the title [-][Bug]: Very strange issue!!! Comment text affects the execution of SQL statements??[/-] [+]Chinese and Japanese comment text affects the execution of SQL statements[/+] on Sep 13, 2024mgrojo commented on Sep 14, 2024 It should be fixed now. @os9sur could you confirm it and close the issue with a nightly or continuous build? Reacted by os9sur Reacted by Justin Clift and os9sur Reacted by os9sur os9sur commented on Sep 15, 2024 Thank you guys!
The issue has been fixed! Reacted by Justin Clift and Manuel justinclift commented on Sep 15, 2024 @mgrojo That fix looks like a good approach. Much less complicated than I was fearing this might turn out to be. 😁 mgrojo commented on Sep 15, 2024
@mgrojo That fix looks like a good approach. Much less complicated than I was fearing this might turn out to be. 😁
I thought the same at first, because this part of the code is complex and Unicode difficult. But at the end, part of the problem was fixed, although only for one end of the string, so I applied a similar approach for the other end.
MetadataMetadataDevelopmentNo branches or pull requestsIssue actions
|