GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow the user can change MaxRecentFiles by lucydodo · Pull Request #2373 · sqlitebrowser/sqlitebrowser

Conversation

@lucydodo

@lucydodo lucydodo commented Aug 15, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I recently made a pull request(#2347) to move the recent file list to a sub-menu and
received a suggestion to change the value of MaxRecentFiles during the review process.

Accordingly, I modified the code to allow the user to change the value of MaxRecentFiles.
In addition, I re-added the separator that was lost according to the existing patch.

Thank you.

Test Environment

  • macOS Catalina (10.15.6, 19G2021)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
SeongTae Jeong added 4 commits August 16, 2020 06:09
SeongTae Jeong
Add spin box for max recent files
77ee448
SeongTae Jeong
Set default value for max recent files
e93f8f1
SeongTae Jeong
Implement handling of max recent files value
37fe028
SeongTae Jeong
Add separator to separate the recent file list and the clear list action
ceb33ae
@justinclift justinclift added the enhancement Feature requests. label Aug 15, 2020
@lucydodo lucydodo changed the title User can change MaxRecentFiles Allow the user can change to the value of MaxRecentFiles Aug 17, 2020
@lucydodo lucydodo changed the title Allow the user can change to the value of MaxRecentFiles Allow the user can change MaxRecentFiles Aug 17, 2020
@lucydodo

lucydodo commented Aug 17, 2020

Copy link
Copy Markdown
Member Author

May I ask for a review of my code?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MKleusberg

MKleusberg commented Aug 17, 2020

Copy link
Copy Markdown
Member

@lucydodo Sure. I'll have a look later today 😄
lucydodo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MKleusberg

MKleusberg commented Aug 17, 2020

Copy link
Copy Markdown
Member

Thanks, @lucydodo! Looks good 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MKleusberg
MKleusberg merged commit 54ee47b into sqlitebrowser:master Aug 17, 2020
@lucydodo

lucydodo commented Aug 17, 2020

Copy link
Copy Markdown
Member Author

Thanks to merge!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Feature requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lucydodo @MKleusberg @justinclift
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.