GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Updates the Portuguese (BR) translations for v3.12.x by bernardosulzbach · Pull Request #2418 · sqlitebrowser/sqlitebrowser

Conversation

@bernardosulzbach

@bernardosulzbach bernardosulzbach commented Oct 2, 2020

Copy link
Copy Markdown
Contributor

This PR is towards #2405.

1
I took care to properly align these strings, but this should probably be done by software. I think you will agree that it makes no sense to require all translators to manually align these strings rather than just splitting each line into two strings and adding as many spaces are required for proper alignment. That would also be less error-prone.
There are now warnings for the Portuguese translation (regarding the different number of leading spaces) because of this.

2
Some of the text in the program is manually line-split, I don't know how much sense this makes as different resolutions and font sizes could make something that looks OK to a developer look very strange to an end-user. Maybe there is a way to get line-wrapping done by software here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bernardosulzbach
Updates the Portuguese (BR) translations (v3.12.x)
6dfefbe
lucydodo
lucydodo requested changes Oct 2, 2020
View reviewed changes

@lucydodo lucydodo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
There are items that need just one simple modifications. Please check them. 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/translations/sqlb_pt_BR.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@lucydodo

lucydodo commented Oct 2, 2020

Copy link
Copy Markdown
Member

I think you will agree that it makes no sense to require all translators to manually align these strings rather than just splitting each line into two strings and adding as many spaces are required for proper alignment.

And I think it is a reasonable opinion.
I will try to figure out a way to make it more readable, even if the translation doesn't add a space in front or back of it. 🤔
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lucydodo lucydodo added the translation label Oct 2, 2020
@bernardosulzbach
Removes empty translations from Portuguese (BR)
c8bdbef
@bernardosulzbach

bernardosulzbach commented Oct 2, 2020

Copy link
Copy Markdown
Contributor Author

@lucydodo I've removed the empty translations.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lucydodo
lucydodo approved these changes Oct 2, 2020
View reviewed changes
@lucydodo
lucydodo merged commit 2c0a91e into sqlitebrowser:v3.12.x Oct 2, 2020
@lucydodo

lucydodo commented Oct 2, 2020

Copy link
Copy Markdown
Member

LGTM! Thanks for modification. Now it just squash and merge. 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucydodo lucydodo lucydodo approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

translation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bernardosulzbach @lucydodo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.