GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add auto completion for math functions by neozest · Pull Request #2631 · sqlitebrowser/sqlitebrowser

Conversation

@neozest

@neozest neozest commented Mar 15, 2021

Copy link
Copy Markdown
Contributor

Math functions are introduced from sqlite 3.35.
Refer https://www.sqlite.org/lang_mathfunc.html
FYI, it need to be compiled with -DSQLITE_ENABLE_MATH_FUNCTIONS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
justinclift and neozest reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@neozest
Add auto completion for math functions
17e930a 
Math functions are introduced from sqlite 3.35.
Refer https://www.sqlite.org/lang_mathfunc.html
FYI, it need to compile sqlite with -DSQLITE_ENABLE_MATH_FUNCTIONS
justinclift
justinclift reviewed Mar 15, 2021
View reviewed changes
Comment thread src/SqlUiLexer.cpp Outdated
<< "first_value" + tr("(expr) This built-in window function calculates the window frame for each row in the same way as an aggregate window function. It returns the value of expr evaluated against the first row in the window frame for each row.")
<< "last_value" + tr("(expr) This built-in window function calculates the window frame for each row in the same way as an aggregate window function. It returns the value of expr evaluated against the last row in the window frame for each row.")
<< "nth_value" + tr("(expr,N) This built-in window function calculates the window frame for each row in the same way as an aggregate window function. It returns the value of expr evaluated against the row N of the window frame. Rows are numbered within the window frame starting from 1 in the order defined by the ORDER BY clause if one is present, or in arbitrary order otherwise. If there is no Nth row in the partition, then NULL is returned.")
// Math functions introduced from SQLite 3.3.5

@justinclift justinclift Mar 15, 2021

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.3.5 → 3.35

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@neozest neozest Mar 15, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo. good catch :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
justinclift reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@justinclift

justinclift commented Mar 15, 2021

Copy link
Copy Markdown
Member

Seems like a good idea in concept. Am kind of wondering if there should be a check for the running SQLite version though, before enabling them?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@neozest
Add auto completion for math function when it had been enabled
1791eaf 
Math function can be used when sqlite is equal or higher than 3.35 and
compiled with SQLITE_ENABLE_MATH_FUNCTIONS. When sqlite is compiled with
SQLITE_OMIT_COMPILEOPTION_DIAGS, there is no way to check the compile
options. In this case, we'll check only the sqlite version. Otherwise,
it will check whether sqlite was built with SQLITE_ENABLE_MATH_FUNCTIONS.
@justinclift

justinclift commented Mar 16, 2021

Copy link
Copy Markdown
Member

@lucydodo @MKleusberg @mgrojo This seems like a good idea to me. Hopefully someone has time to review it. 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@justinclift
justinclift requested review from MKleusberg, lucydodo and mgrojo March 16, 2021 01:01
@MKleusberg
MKleusberg merged commit fb80d3b into sqlitebrowser:master Mar 16, 2021
@MKleusberg

MKleusberg commented Mar 16, 2021

Copy link
Copy Markdown
Member

Awesome! Thank you very much, @neozest! This is very much appreciated 😄
justinclift reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@justinclift justinclift added this to the 3.13.0 - Future release milestone Mar 17, 2021
@mgrojo mgrojo added enhancement Feature requests. sqlite labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinclift justinclift justinclift left review comments
@MKleusberg MKleusberg Awaiting requested review from MKleusberg
@lucydodo lucydodo Awaiting requested review from lucydodo
@mgrojo mgrojo Awaiting requested review from mgrojo

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

enhancement Feature requests. sqlite

Projects

None yet

Milestone

3.13.0 - Future release

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@neozest @justinclift @MKleusberg @mgrojo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.