GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — SpatiaLite to SVG display format by sandman7920 · Pull Request #2767 · sqlitebrowser/sqlitebrowser

Conversation

@sandman7920

@sandman7920 sandman7920 commented Jul 12, 2021

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
justinclift reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
sandman7920 added 2 commits July 12, 2021 16:24
@sandman7920
ColumnDisplayFormatDialog: Escape column_name only once
64d86a0
@sandman7920
ColumnDisplayFormatDialog: Added SpatiaLite geometry to SVG Display F…
4e5f117 
…ormat

The new Display Format should convert SpatiaLite geometry (BLOB) into SVG.
By default the geometry is scaled to 320 pixels (0..319)
@sandman7920
sandman7920 requested a review from mgrojo July 12, 2021 13:47
@justinclift

justinclift commented Jul 12, 2021

Copy link
Copy Markdown
Member

Cool. When we merge this, lets do:

  • A blog post with at least an example + screenshot
  • Make sure the nightly builds have been run, so we can point people at downloads that have the functionality for this in it

Pretty sure it'll be a useful feature for people that do GIS stuff. 😄
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sandman7920 added 5 commits July 13, 2021 14:34
@sandman7920
ImageViewer: initialize m_scale_factor with default value
78a1209
@sandman7920
ImageViewer: Use scrollArea widget for boundaries check
daee6bc 
Check if the image is inside the scrollArea widget,
not the "scrollable content".
@sandman7920
ImageViewer: Keep aspect ratio for a scaled image
d2e957c
@sandman7920
ImageViewer: Change image alignment to center
f97d101
@sandman7920
ImageViewer: Added mouse pan mode
d62ccb1
mgrojo
mgrojo requested changes Jul 13, 2021
View reviewed changes

@mgrojo mgrojo left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please check the duplicated line, which seems unintended, but otherwise, I think it can be merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/ImageViewer.ui Resolved

Uh oh!

There was an error while loading. Please reload this page.
sandman7920 added 2 commits July 14, 2021 09:34
@sandman7920
ImageViewer: Code cleanup
c4dd27e
@sandman7920
ColumnDisplayFormatDialog: geomToSVG change default resolution to 640
4a0ba0d
@sandman7920
sandman7920 merged commit 67a70dd into sqlitebrowser:master Jul 14, 2021
@justinclift

justinclift commented Jul 19, 2021

Copy link
Copy Markdown
Member

Ahhh, cool. Didn't realise this had been merged.

We should probably do some promo of this via the website or something.

@sandman7920 Do you have an example database with SVG data in it that I can load and take some screenshots of? Hmmm, unless you're ok to do the screenshots, and I'll throw them on the website in a blog post.

Oh, if you want to write blog post stuff, you're definitely welcome to. No-one else but me seems to, and I'd like to kind of spread that around a bit. 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@justinclift justinclift self-assigned this Jul 19, 2021
@sandman7920

sandman7920 commented Aug 2, 2021

Copy link
Copy Markdown
Contributor Author

@justinclift I have posted in the developer's team, I don't know if you read the post.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@justinclift

justinclift commented Aug 2, 2021 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Sorry, yeah. It's just been a very busy few weeks. I'll get around to it in the near-ish future. 😄

As a reminder, everyone in the team has write access to the blog. So, everyone can write blog posts and they'll automatically appear on the website (it checks for new commits, and updates every 10 mins). 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgrojo mgrojo mgrojo requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@justinclift justinclift

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sandman7920 @justinclift @mgrojo
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.