GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — extension(macOS): Include 'nalgeon/sqlean' extension to the app bundle by lucydodo · Pull Request #3517 · sqlitebrowser/sqlitebrowser

Conversation

@lucydodo

@lucydodo lucydodo commented Dec 9, 2023

Copy link
Copy Markdown
Member

Related: #3357

Since this PR changes include the external projects' library to our project, so I've added a license disclaimer.
I also left a PR for the same reason, because I think it's only fair that both owners review it before committing it right away.

@nalgeon You are the owner of the project we want to include, so I ping you together. :)

Thank you.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lucydodo
extension(macOS): Include 'nalgeon/sqlean' extension to the app bundle
0561d3f 
Related: #3357
@lucydodo lucydodo added macOS extensions labels Dec 9, 2023
@lucydodo
lucydodo requested a review from justinclift December 9, 2023 03:35
@lucydodo lucydodo self-assigned this Dec 9, 2023
@lucydodo

lucydodo commented Dec 9, 2023

Copy link
Copy Markdown
Member Author

https://www.youtube.com/watch?v=FM5TSX9JRA8
I've also prepared a simple demostration video that loads and uses the newly included sqlean library.

GitHub can't upload video files larger than 10MB, so I inevitably upload to YouTube.
justinclift reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
justinclift
justinclift reviewed Dec 9, 2023
View reviewed changes
Comment thread .github/actions/notarize-macos/action.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
justinclift
justinclift approved these changes Dec 9, 2023
View reviewed changes

@justinclift justinclift left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😄

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lucydodo reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@nalgeon

nalgeon commented Dec 9, 2023

Copy link
Copy Markdown

Looks great!
justinclift reacted with thumbs up emoji lucydodo reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@justinclift
justinclift merged commit 96686a7 into master Dec 9, 2023
@justinclift
justinclift deleted the fix-3357 branch December 9, 2023 18:52
@justinclift

justinclift commented Dec 9, 2023

Copy link
Copy Markdown
Member

Cool. k, I've just hit the Merge button, so lets see if it all works properly... 😄
nalgeon and lucydodo reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinclift justinclift justinclift approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@lucydodo lucydodo

Labels

extensions macOS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@lucydodo @nalgeon @justinclift
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.