GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Fix foreign keys being skipped when renaming a column by deepsidhu1313 · Pull Request #4226 · sqlitebrowser/sqlitebrowser Conversation
Contributor
Table::renameKeyInAllConstraints() looped over m_foreignKeys with for(...; ++it) while the match_and_rename helper already advances the iterator (it = container.erase(it)). After a rename the loop skipped the next foreign key, leaving it on the old column name, and when the renamed entry was the last one it incremented end(), which is undefined behaviour. Let the helper advance the iterator, like the index constraint loop above. Add tests for renaming keys in foreign keys and index constraints, and a regression test for moving an AUTOINCREMENT primary key (#3953). Likely fixes #3994
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsTable::renameKeyInAllConstraints() looped over m_foreignKeys with for(...; ++it) while the match_and_rename helper already advances the iterator (it = container.erase(it)). After a rename the loop skipped the next foreign key, leaving it on the old column name, and when the renamed entry was the last one it incremented end(), which is undefined behaviour. Let the helper advance the iterator, like the index constraint loop above. Add tests for renaming keys in foreign keys and index constraints, and a regression test for moving an AUTOINCREMENT primary key (sqlitebrowser#3953). Likely fixes sqlitebrowser#3994 Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
deepsidhu1313
force-pushed
the
fix/rename-foreign-key-iterator
branch
from
abe0a6c to
00dffe3
Compare
This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. [Bug]: Crash when changing primary key in Modify Table windowUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |