GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Feature/edit table generated columns by deepsidhu1313 · Pull Request #4228 · sqlitebrowser/sqlitebrowser

Conversation

@deepsidhu1313

@deepsidhu1313 deepsidhu1313 commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Add SQL round trip tests for VIRTUAL and STORED generated columns and a
test that Field/Table comparison notices changes to the generated column
definition (alterTable relies on it to detect modified tables).

Add an offscreen test (test-edit-table) which drives the Edit Table
dialog against a real database: showing, adding, changing and removing
generated columns, switching between VIRTUAL and STORED, adding a STORED
column to a table with data, and the primary key / default value
restrictions. These fail for now as the dialog has no support for
generated columns yet.

Co-Authored-By: Claude Sonnet 5.5 [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
claude added 5 commits October 25, 2026 04:21
@claude
Add failing tests for generated columns in the Edit Table dialog
e907550
Add SQL round trip tests for VIRTUAL and STORED generated columns and a
test that Field/Table comparison notices changes to the generated column
definition (alterTable relies on it to detect modified tables).

Add an offscreen test (test-edit-table) which drives the Edit Table
dialog against a real database: showing, adding, changing and removing
generated columns, switching between VIRTUAL and STORED, adding a STORED
column to a table with data, and the primary key / default value
restrictions. These fail for now as the dialog has no support for
generated columns yet.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
Support generated columns in the Edit Table dialog
1be82d9
Add a "Generated" column to the field list which holds the expression of
a generated column (empty for ordinary columns) and a "Stored" checkbox
column which switches the column from VIRTUAL, the default, to STORED.
Both are filled from the existing table and applied to the field when
edited. See sqlitebrowser#2107.

Generated columns can't be part of the primary key and can't have a
default value, so the dialog refuses these combinations. Turning an
existing column into a generated column replaces its data, so the user
has to confirm that first.

SQLite can't add a STORED column with ALTER TABLE ADD COLUMN, so
alterTable() now leaves those to the table rebuild it does anyway.

Field::operator== ignored the generated column constraint which made
alterTable() believe nothing had changed when only the generated column
expression or storage was edited. Compare it by value now.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
Let test-edit-table find the SQLite DLL on Windows
c2b26ab
test-global-filter needs the CMake prefix paths on PATH on Windows
because the CI jobs build SQLite as a DLL there. test-edit-table links
SQLite too and would crash on Windows without them.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
Build test-edit-table with Qt6 UI connections
7f0a4f6
The .ui files connect to slots that don't exist in Qt6 (QDialog::help)
unless uic generates string based connections. The main target already
sets this option for Qt6, but test-edit-table compiles the dialogs' .ui
files as well and would fail to build with Qt6.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
@claude
Fix test-edit-table on SQLCipher and Windows
3f0a3b7
Link CipherDialog into test-edit-table, which sqlitedb.cpp needs when it
is built with SQLCipher. Skip the three tests that have the dialog show
a message box on Windows, where QMessageBox::showEvent() crashes with the
offscreen platform.

Co-Authored-By: Claude Sonnet 5.5 <[email protected]>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@deepsidhu1313 @claude
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.