GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — Detect statement type in Execute SQL despite leading comments by deepsidhu1313 · Pull Request #4233 · sqlitebrowser/sqlitebrowser Conversation
Contributor
RunSql::getQueryType() looked at the start of the statement text, but the text SQLite hands back for a statement includes any comments in front of it. A script like "-- compact\nVACUUM;" was therefore classified as an ordinary statement, wrapped in a savepoint and failed with "cannot VACUUM from within a transaction" (the same applies to VACUUM INTO and to PRAGMA statements that must run outside of a transaction). Skip whitespace and comments before matching the keyword. Add a test-run-sql target which runs scripts through RunSql against a real database.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsRunSql::getQueryType() looked at the start of the statement text, but the text SQLite hands back for a statement includes any comments in front of it. A script like "-- compact\nVACUUM;" was therefore classified as an ordinary statement, wrapped in a savepoint and failed with "cannot VACUUM from within a transaction" (the same applies to VACUUM INTO and to PRAGMA statements that must run outside of a transaction). Skip whitespace and comments before matching the keyword. Add a test-run-sql target which runs scripts through RunSql against a real database. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersNo reviewsUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |