Description

risicle

opened on Dec 12, 2021

Issue body actions

In preparing the NixOS package for 3.9.1, we noticed the test_fail test failed. This is when run against paste 3.5.0 on x86_64 linux with python 3.8 or 3.9.

__________________________________ test_fail ___________________________________

    def test_fail():
        setup()
        assert not runapp(fail=True, use_transaction=True)
        assert names() == []
        setup()
        assert not runapp(fail=True, use_transaction=False)
        assert names() == ['app1', 'app2']
        setup()
        assert not runapp(fail=True, begin=True, use_transaction=True)
>       assert names() == ['app1']
E       AssertionError: assert ['app1', 'app2'] == ['app1']
E         Left contains one more item: 'app2'
E         Use -v to get the full diff

sqlobject/tests/test_paste.py:75: AssertionError

It seems as though the transaction is failing to be rolled back when the assertion failure at

sqlobject/sqlobject/tests/test_paste.py

Line 28 in c3933b8

assert 0

causes execution to fall out of the app.

Full build log available at https://hydra.nixos.org/log/mbdj9hkzf2ixqjlqfixskhvss838jpvf-python3.8-SQLObject-3.9.1.drv

Activity

1. phdru

   self-assigned this

   on Dec 12, 2021
2. phdru

   added

   bug

   on Dec 12, 2021
3. phdru commented on Dec 12, 2021

   

   phdru

   on Dec 12, 2021

   Member

   More actions

   Thank you for reporting! Working with Paste was added by the Paste and SQLObject original author Ian Bicking. In about 20 year that I use and maintain SO I never used Paste.

   So 1st I need to find a way to reproduce the problem. It would be better and faster if someone lends a hand.
4. risicle commented on Dec 13, 2021

   

   risicle

   on Dec 13, 2021

   Author

   More actions

   Does it not fail for you with those versions?
5. phdru commented on Dec 15, 2021

   

   phdru

   on Dec 15, 2021

   Member

   More actions

   I have never installed Paste so the test was always skipped. And nobody reported any problem. Until now. So the 1st thing will be to to add Paste to the list of dependencies and rerun tests.
6. phdru commented on Dec 15, 2021

   

   phdru

   on Dec 15, 2021

   Member

   More actions

   I installed Paste but the test failed at from paste.deploy.converters import asbool — Paste doesn't have subpackage paste.deploy. Do I need older version of Paste? Additional package(s)?

   Upd. Found: https://pypi.org/project/PasteDeploy/ . The bug is reproduced.
7. phdru commented on Feb 21, 2022

   

   phdru

   on Feb 21, 2022

   Member

   More actions

   Commit 9f3ca7e fixes the second problem:

   sqlite3.ProgrammingError: SQLite objects created in a thread can only be used in that same thread. The object was created in thread id 140737345897280 and this is thread id 140737311536704.

   I was sure it should fix the entire bug too but it doesn't. It seems the problem is bigger and deeper.

Issue actions